Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor ruby files to follow Ruby Style Guide #6340
This is referenced from the issue: #6314.
To remove linting errors using rubocop
Since currently there are more than 6000 offenses I would like to break this into smaller issues, also I would like to track them all in this issue.
Active issues as of now are listed below, please feel free to create a new issue for any other directory and start refactoring the ruby files in that directory. Please reference this issue in every issue that you create for each directory so that we will have a single issue to track the progress.
Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Yes please, this would be great!…
On Mon, Sep 30, 2019 at 5:31 AM newbazz ***@***.***> wrote: yes i think this is a good first step, you can file an issue and start working on the same. @moki298 <https://github.com/moki298> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6340?email_source=notifications&email_token=AAAF6J5JOZF7TGKIZAXTCL3QMHBLRA5CNFSM4I27DZ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD75BCHA#issuecomment-536482076>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J2FRC3DBTGSA656KEDQMHBLRANCNFSM4I27DZ7A> .
Is it any better if we do this single directory at a time? Also, how can I test locally once I do any changes? Is there a defined workflow for this?
@camillesk @discombobulateme thanks for your interest. I believe we should break this into smaller issues. But I am waiting for comments from the @jywarren @newbazz to know what they think about this as I am new to this repo and ruby world. I would like to wait and see for a week or so and then I would start breaking this into smaller issues.
Meanwhile, it would be great if you have the environment setup and ready. @discombobulateme I think rubocop it the best way to update this codebase, manual checking is ineffective for dealing with 6000 plus offenses.
Clone this repo and install the required software and then install rubocop with instructions from here and then run rubocop from this repo you should be able to see all the offenses listed.