Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back to top button for mobile view #6352

Open
pydevsg opened this issue Sep 29, 2019 · 8 comments

Comments

@pydevsg
Copy link

commented Sep 29, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

See this page for some help in taking your first steps!

In the current UI the back to top button is too big and it hides some content

Previously(current UI) - backtotop

After giving the media queries with some css, this can be solved

Inside the media query add the given css

@media (max-width:400px) {
.back-to-top i {
font-size: 40px;
position: fixed;
bottom: 20px;
right: 20px;
}
}

Expected UI change after doing the above step will be -
ExpectedUI backtotop (Updated)

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@welcome

This comment has been minimized.

Copy link

commented Sep 29, 2019

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@shiv-1998

This comment has been minimized.

Copy link

commented Sep 30, 2019

Hi can I work on this?

@shiv-1998

This comment has been minimized.

Copy link

commented Sep 30, 2019

I've raised a PR for the same.

@pydevsg

This comment has been minimized.

Copy link
Author

commented Sep 30, 2019

Change your PR a bit and add the Issue Number with it and then your 1st PR will be merged 😄

shiv-1998 added a commit to shiv-1998/plots2 that referenced this issue Sep 30, 2019
Fixing Back To Top Button for Mobile View.
@Askat08

This comment has been minimized.

Copy link

commented Oct 1, 2019

Hi there, may I take this up?

@garg3133

This comment has been minimized.

Copy link

commented Oct 1, 2019

@pydevsg Sorry! But I'm unable to understand how can the fix given by you solve the problem? The back to top button is causing problems in small screens (360px width as shown in screenshot), right! But the change you have suggested will decrease the size of back to top button for screens bigger than 400px as you have written "min-witdh:400px" in the media query.

@media (min-width:400px) {

I think it should be "max-width:400px". Please correct me if I'm wrong.

Thank You!

@pydevsg

This comment has been minimized.

Copy link
Author

commented Oct 1, 2019

@garg3133 Thankyou very much for your valuable correction, actually it will be max-width not min-width, I agree with you. I fixed it but there was a small typo from my side. Btw @garg I have helped @shiv-1998 with it and he have corrected the same previously. :)

@pydevsg

This comment has been minimized.

Copy link
Author

commented Oct 1, 2019

Hi @Askat08, a PR has already been given for this issue you can check for first timers issues and fto from - code.publiclab.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.