Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dashboard.css by removing the empty rulesets #6454

Closed
5 tasks
susanreenesaa opened this issue Oct 13, 2019 · 6 comments · Fixed by #6463
Closed
5 tasks

update dashboard.css by removing the empty rulesets #6454

susanreenesaa opened this issue Oct 13, 2019 · 6 comments · Fixed by #6463
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@susanreenesaa
Copy link
Contributor

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file $FILENAME in the $REPO repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Steps to fixe the issue
navigate to
plots2/app/assets/stylesheet/dashboard.css in the public lab projects directory.
image
Remove the CSS code on lines 219,220,2021 (remove lines 2019 to 2021)
NOTE
After removing the empty rulesets the error highlighted at the bottom of the page should disappear
The error is Don't use empty rulesets ... so it should show no problems have been detected in the workspace so far.
image
Expected result
image

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@susanreenesaa susanreenesaa added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Oct 13, 2019
@welcome
Copy link

welcome bot commented Oct 13, 2019

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@susanreenesaa susanreenesaa changed the title update dashboar.css by removing the empty rulesets update dashboard.css by removing the empty rulesets Oct 13, 2019
@steric85
Copy link

Hello @susanreenesaa
I am interested in this issue. Can I claim it?

@steric85
Copy link

@susanreenesaa Please review #6455 :)

@susanreenesaa
Copy link
Contributor Author

@steric85. Sorry for the delay. I don't have the right to merge your pull request. but if you are an outrechy applicant, you can ask your mentor to make a pull request or ask on the public channel.
@IshaGupta already reviewed your pull request so if you can access the merge button, click it to merge your request. if not ask for help as I suggested above. thanks

@steric85
Copy link

@susanreenesaa Thanks for the response.
I don't have the access to merge. Also, I am not an outrechy applicant.
@IshaGupta18 Can you please help here?

@IshaGupta18
Copy link
Collaborator

IshaGupta18 commented Oct 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants