Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon hover color on "like" buttons #6516

Open
nstjean opened this issue Oct 22, 2019 · 11 comments · Fixed by textuallyactive/plots2#1 · May be fixed by #6741

Comments

@nstjean
Copy link
Contributor

@nstjean nstjean commented Oct 22, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _like.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Just after these lines of code:

.like-buttons {
margin-top:5px;
}

Add this code in:

.like-buttons a .fa, .popover .btn-group a .fa {
  color: inherit;
}

This is what the drop down looks like before the change:
FireShot Capture 019 - 🎈 Public Lab_ Anyone working on low cost plants_ - localhost

And this is what it will look like after!
FireShot Capture 020 - 🎈 Public Lab_ Anyone working on low cost plants_ - localhost

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Oct 22, 2019

This is reserved for @textuallyactive

@sap143

This comment has been minimized.

Copy link

@sap143 sap143 commented Oct 22, 2019

I wanted to start my journey in contributing to open source.

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Oct 22, 2019

Hi @sap143 ! This issue is reserved for someone, but you can add your name to the list here: #6206 :) Welcome!

@sap143

This comment has been minimized.

Copy link

@sap143 sap143 commented Oct 22, 2019

Thanks You
Added my name to the list #6206

@avinash080

This comment has been minimized.

Copy link

@avinash080 avinash080 commented Oct 23, 2019

is this issue open?

@textuallyactive

This comment has been minimized.

Copy link

@textuallyactive textuallyactive commented Oct 23, 2019

Thank you. Would do a PR as soon as I get access to a laptop. Cheers!

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Oct 23, 2019

@avinash080 Sorry, someone is already working on this issue. If you would like to be assigned an issue you can add your name to the list here: #6206

@avinash080

This comment has been minimized.

Copy link

@avinash080 avinash080 commented Oct 23, 2019

@nstjean ok so plz tell me if there's any issue open . this is my first time on github.

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Oct 23, 2019

@avinash080 We will let you know in the other thread. :) Thanks for being here and for being patient!

@krystelufe

This comment has been minimized.

Copy link

@krystelufe krystelufe commented Oct 23, 2019

I am an outreachy applicant . Pls I need a first timer issue to start working on. thanks

@textuallyactive

This comment has been minimized.

Copy link

@textuallyactive textuallyactive commented Oct 24, 2019

Done!
However, I don't know who to tag for reviewing. Thank you for everything again!

@preetiy preetiy referenced a pull request that will close this issue Nov 8, 2019
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.