Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change function t to translations in dashboard/_comment_moderate #6551

Open
nstjean opened this issue Oct 25, 2019 · 9 comments

Comments

@nstjean
Copy link
Contributor

@nstjean nstjean commented Oct 25, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _comment_moderate.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

In this template we need to change the function named t(....) to be named as translations(...) on lines 4, 5, 6 and 8.

<%= t('dashboard._comment_moderate.first_time_post') %>
<a class="btn btn-outline-secondary btn-sm" href="/admin/publish_comment/<%= comment.id %>"><%= t('dashboard.moderate.approve') %></a>
<a class="btn btn-outline-secondary btn-sm" href="/admin/mark_comment_spam/<%= comment.id %>"><%= t('dashboard.moderate.spam') %></a>
<% else %>
<%= raw t('dashboard.moderate.pending_approval', :url => '/wiki/moderation') %>

After the changes it should look like this:

      <%= translation('dashboard._comment_moderate.first_time_post') %>
      <a class="btn btn-outline-secondary btn-sm" href="/admin/publish_comment/<%= comment.id %>"><%= translation('dashboard.moderate.approve') %></a>
      <a class="btn btn-outline-secondary btn-sm" href="/admin/mark_comment_spam/<%= comment.id %>"><%= translation('dashboard.moderate.spam') %></a>
    <% else %>
      <%= raw translation('dashboard.moderate.pending_approval', :url => '/wiki/moderation') %>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Oct 25, 2019

Reserved for @saivoleti17

@jaywahr

This comment has been minimized.

Copy link
Contributor

@jaywahr jaywahr commented Oct 25, 2019

@nstjean how can I get on a "wait list" to get a first-timers-only issue? Thank you.

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Oct 25, 2019

Hi @jaywahr - our list is located here: #6206 Just post and we will add you to the list! We'll get new issues up soon!

@cesswairimu

This comment has been minimized.

Copy link
Collaborator

@cesswairimu cesswairimu commented Oct 27, 2019

@saivoleti17 already have a fto here publiclab/mapknitter#1086 ... @boolean5 you can solve this. Thanks all

@boolean5

This comment has been minimized.

Copy link

@boolean5 boolean5 commented Oct 27, 2019

Thank you @cesswairimu. I'm on it.

@boolean5

This comment has been minimized.

Copy link

@boolean5 boolean5 commented Oct 27, 2019

Now I see that @saivoleti17 has already submitted a PR (#6555) for this issue. I think it would be fair to let them complete their work. Please, let me know if any help is needed.

@cesswairimu

This comment has been minimized.

Copy link
Collaborator

@cesswairimu cesswairimu commented Oct 27, 2019

Cool no worries

@Anand-Theertha

This comment has been minimized.

Copy link

@Anand-Theertha Anand-Theertha commented Oct 28, 2019

Hello! I saw this issue under "No one assigned". Does this mean I can work on it even though it has been reserved for somebody? @nstjean

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Oct 29, 2019

Hi @Anand-Theertha ! There is already a pull request for this issue. We'll be making more first-time-only issues!

@nstjean nstjean referenced this issue Oct 30, 2019
29 of 75 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.