Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change function t to translation in dashboard/_node_question #6603

Open
nstjean opened this issue Nov 2, 2019 · 9 comments

Comments

@nstjean
Copy link
Contributor

@nstjean nstjean commented Nov 2, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _node_question.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

In this template we need to change the function named t(....) to be named as translation(...) on line 18.

<p class="meta"><%= t('dashboard._node_question.question') %> <%= render partial: "dashboard/node_meta", locals: { node: node } %></p>

Change to:

      <p class="meta"><%= translation('dashboard._node_question.question') %> <%= render partial: "dashboard/node_meta", locals: { node: node } %></p>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@klaffert

This comment has been minimized.

Copy link
Contributor

@klaffert klaffert commented Nov 2, 2019

Would love to take this one on! @nstjean

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Nov 2, 2019

@klaffert Hi, go ahead!

klaffert added a commit to klaffert/plots2 that referenced this issue Nov 4, 2019
Change function t to translation in dashboard/_node_question publiclab#6603
publiclab#6603
@klaffert

This comment has been minimized.

Copy link
Contributor

@klaffert klaffert commented Nov 4, 2019

@nstjean All done. Let me know if there's any feedback and thanks!

@gptshubham595

This comment has been minimized.

Copy link
Member

@gptshubham595 gptshubham595 commented Nov 5, 2019

May I take this issue
SOME MORE LINES HAVE TO BE CHANGED IN THIS
as it around 3 days and not solved

@Devang-25

This comment has been minimized.

Copy link

@Devang-25 Devang-25 commented Nov 5, 2019

@nstjean Can I claim this one?
I have already committed and pulled 3 requests.
Let me know.

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Nov 5, 2019

@gptshubham595 @Devang-25 There is already a pull request submitted for this issue.

@Devang-25 These FTO issues are for people who have never submitted a Pull Request before. You can look at https://code.publiclab.org/ (scroll down to "What's next?") for some suggestions on what your next steps can be!

@klaffert

This comment has been minimized.

Copy link
Contributor

@klaffert klaffert commented Nov 5, 2019

Hi @nstjean is there anything else that needs to be completed on this one? Thanks!

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Nov 6, 2019

@klaffert It should be all set! Someone will merge it soon. :)

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Nov 6, 2019

If you are looking for something more to do you can check this page here https://code.publiclab.org/ and scroll down to "What's next?" It has some ideas and links! We also recommend cloning our repository/ies and getting them working on your development machine.
Installation instructions: https://github.com/publiclab/plots2/blob/master/README.md

SidharthBansal added a commit that referenced this issue Nov 6, 2019
Change function t to translation in dashboard/_node_question #6603
#6603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.