Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile dropdown menu gets cut off on smaller screens #6692

Open
susanreenesaa opened this issue Nov 5, 2019 · 6 comments

Comments

@susanreenesaa
Copy link
Contributor

@susanreenesaa susanreenesaa commented Nov 5, 2019

Referencing Issue #6574
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open-source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file $FILENAME in the $REPO repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF

Problem
Currently, the navigation bar is fixed on top. The issue is that on a smaller screen( ie mobile phone or minimize Pc screen to phone screen size), one is unable to view all the elements in the dropdown menu. as shown below
url https://publiclab.org/ or https://publiclab.org/blog

image

Expected
the menu should be scrollable so as to view all menu elements. (see image below)
image

to make changes, navigate to plots2/app/views/layouts/_header.html.erb
at the extreme end of the file in (<style>..... </style>)and the code below (add lines 188 to 194)

<style> @media (max-width: 767px){ .navbar{ max-height: 100vh; overflow-y: auto; -webkit-overflow-scrolling:touch; } } </style>

code to be added as shown in blue on the right side of the picture
image

@susanreenesaa susanreenesaa changed the title Make the SignUp popup responsive #6572 Make the SignUp popup responsive Nov 5, 2019
@TedTran2019

This comment has been minimized.

Copy link

@TedTran2019 TedTran2019 commented Nov 5, 2019

May I please give it a shot?

@swathi-0901

This comment has been minimized.

Copy link

@swathi-0901 swathi-0901 commented Nov 6, 2019

@susanreenesaa can I work on this issue?

@nitish81299

This comment has been minimized.

Copy link

@nitish81299 nitish81299 commented Nov 6, 2019

@susanreenesaa I would like to work on the issue.

@nitish81299

This comment has been minimized.

Copy link

@nitish81299 nitish81299 commented Nov 6, 2019

@susanreenesaa
I have made a PR for the above issue, have a look.

@susanreenesaa

This comment has been minimized.

Copy link
Contributor Author

@susanreenesaa susanreenesaa commented Nov 8, 2019

sorry for the delay in reply

@susanreenesaa susanreenesaa changed the title Make the SignUp popup responsive Profile dropdown menu gets cut off on smaller screens Nov 8, 2019
@susanreenesaa

This comment has been minimized.

Copy link
Contributor Author

@susanreenesaa susanreenesaa commented Nov 8, 2019

@jywarren help me review this. I tried to but I have no clue where to find the file to review. maybe you can give me direction on how to do it. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.