Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand use of x icon for tags #6849

Closed
jywarren opened this issue Nov 25, 2019 · 10 comments
Closed

Expand use of x icon for tags #6849

jywarren opened this issue Nov 25, 2019 · 10 comments

Comments

@jywarren
Copy link
Contributor

@jywarren jywarren commented Nov 25, 2019

Please note we are preparing to participate in Google Code-in, and have reserved this issue for GCI participants - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

Follow-up to #6791, we have the new icons working for newly added tags but not for existing ones, as shown below; see

image

versus any of the older tags which still use an x character instead of an icon.

Screenshot_20191123-155359
To fix this, we'll need to replace the x character on these two lines, with the same icon as in #6791 --

<i class='fa fa-times-circle fa-white blue pl-1' aria-hidden='true' ></i>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@jywarren

This comment has been minimized.

Copy link
Contributor Author

@jywarren jywarren commented Nov 25, 2019

Published on GCI dashboard. Thanks

@jywarren

This comment has been minimized.

Copy link
Contributor Author

@jywarren jywarren commented Dec 2, 2019

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Dec 3, 2019

@kubakorniluk this task is intended for GCI. Only GCI students are requested to solve this task. If you are not a GCI student then please see other tasks which don't have GCI label.
Thanks

@MariMachaidze

This comment has been minimized.

Copy link

@MariMachaidze MariMachaidze commented Dec 5, 2019

hey, I just claimed this task.

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Dec 5, 2019

@MariMachaidze

This comment has been minimized.

Copy link

@MariMachaidze MariMachaidze commented Dec 5, 2019

Where can I see the code to fix?

@jywarren

This comment has been minimized.

Copy link
Contributor Author

@jywarren jywarren commented Dec 5, 2019

Hi, I wonder if this has been fixed by @nstjean already? I believe it is already updated on PublicLab.org. I'm sorry if this got mixed up! Thank you!

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Dec 6, 2019

@nstjean please look into this. If it is fixed already then we can give MariMachaidze approval on the dashboard so that other GCI students will not claim this task.
Thanks

@nstjean

This comment has been minimized.

Copy link
Contributor

@nstjean nstjean commented Dec 6, 2019

Oh no! I'm sorry! I think I did. :(

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Dec 6, 2019

@SidharthBansal SidharthBansal mentioned this issue Dec 9, 2019
20 of 58 tasks complete
@jywarren jywarren closed this Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.