Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Add a location" appear on all pages which have no location #6857

Closed
jywarren opened this issue Nov 26, 2019 · 2 comments · Fixed by #6876
Closed

Make "Add a location" appear on all pages which have no location #6857

jywarren opened this issue Nov 26, 2019 · 2 comments · Fixed by #6876

Comments

@jywarren
Copy link
Contributor

@jywarren jywarren commented Nov 26, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file $FILENAME in the $REPO repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Pages like https://publiclab.org/wiki/london-uk have a prompt to add a location:

image

However, that little box only shows if a) there are no coordinates for that page, and b) there is a "place" tag on the page. Let's remove the 2nd condition so it appears on all pages that lack coordinates. We'll just need to remove the @node&.has_power_tag('place') part of the condition on this line:

<% elsif @node&.has_power_tag('place') && !@node.lat && !@node.lon %>

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@gabrielrumiranda

This comment has been minimized.

Copy link
Contributor

@gabrielrumiranda gabrielrumiranda commented Nov 26, 2019

Can I Take this issue ?

@jywarren

This comment has been minimized.

Copy link
Contributor Author

@jywarren jywarren commented Nov 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.