Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tag parenting UI from templates #6864

Closed
jywarren opened this issue Nov 27, 2019 · 9 comments · Fixed by #6901
Closed

Remove tag parenting UI from templates #6864

jywarren opened this issue Nov 27, 2019 · 9 comments · Fixed by #6901

Comments

@jywarren
Copy link
Contributor

@jywarren jywarren commented Nov 27, 2019

Please note we are preparing to participate in Google Code-in, and have reserved this issue for GCI participants - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

Let's remove this section from the code, as we are no longer providing this admin feature!

<% if logged_in_as(['admin']) %>
<div class="dropdown-item">
<div id="add_parent">
<p><b>Add a tag parent (admin only)</b></p>
<form class="form" action="/tag/parent" method="get">
<div class="control-group">
<div class="input-group">
<input class="form-control" type="text" placeholder="parent" name="parent" />
<input type="hidden" placeholder="parent" name="name" value="<%= @tags&.first&.name %>" />
<div class="input-group-append">
<input class="btn btn-outline-secondary" type="submit" value="Submit" />
</div>
</div>
</div>
</form>
</div>
</div>
<% end %>

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Nov 28, 2019

Published

@myungwoo-Y

This comment has been minimized.

Copy link

@myungwoo-Y myungwoo-Y commented Nov 29, 2019

Can I take this issue?

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Nov 29, 2019

Hi, this issue is reserved for GCI students. So, you can't work on it if you are not GCI student.
Please see other issues which are not labelled with gci based labels.
Thanks

@chen-robert

This comment has been minimized.

Copy link
Contributor

@chen-robert chen-robert commented Dec 3, 2019

Hello @SidharthBansal, can I claim this task?

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Dec 4, 2019

You can claim it after completing installation task for plots2.
Thanks

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Dec 4, 2019

And please ping all the mentors of the repo instead of only one mentor. As time zones vary a lot

@CodeSarthak

This comment has been minimized.

Copy link
Collaborator

@CodeSarthak CodeSarthak commented Dec 13, 2019

Hey, this task is still there on GCI but it is closed here. Please take appropriate action @SidharthBansal @jywarren

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Dec 13, 2019

Can you please check whether this task is completed or not?

@SidharthBansal

This comment has been minimized.

Copy link
Member

@SidharthBansal SidharthBansal commented Dec 13, 2019

@chen-robert did you take points for this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.