Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the function t to translation of app/views/users/_likes.html.erb #6880

Open
govindgoel opened this issue Nov 29, 2019 · 8 comments
Open

change the function t to translation of app/views/users/_likes.html.erb #6880

govindgoel opened this issue Nov 29, 2019 · 8 comments

Comments

@govindgoel
Copy link
Member

@govindgoel govindgoel commented Nov 29, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file $FILENAME in the $REPO repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!
You can find the filehere:
"https://github.com/publiclab/plots2/blob/master/app/views/users/likes.html.erb"
Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:
You only have to edit the function t and not the whole line.
change function t to translation in lines 6,11,15 and 23 respectively.After changing the lines should look like below: "

 <%= translation('users.likes.wiki_liked_by') %> <%= user.name %>"><%= user.name %>
  <%= wiki.title %> (<%= translation('users.likes.updated') %><%= distance_of_time_in_words(wiki.updated_at, Time.current, { include_seconds: false, scope: 'datetime.time_ago_in_words' }) %>)
 
<%= translation('users.likes.more') %>
 
 <%= translation('users.likes.liked_by') %> <%= user.name %>"><%= user.name %>

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@welcome

This comment has been minimized.

Copy link

@welcome welcome bot commented Nov 29, 2019

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@govindgoel govindgoel mentioned this issue Nov 29, 2019
31 of 75 tasks complete
@nstjean

This comment has been minimized.

Copy link
Contributor

@nstjean nstjean commented Nov 30, 2019

Hi @govindgoel ! Thanks for helping!! Can you include a link to the file in the post? Are the line numbers 6, 11, 15 and 23 correct? Right now that code looks like it's all one piece to copy and paste, it could be confusing.

@govindgoel

This comment has been minimized.

Copy link
Member Author

@govindgoel govindgoel commented Nov 30, 2019

Yeah thanks for suggestion I have updated the info..
Happy Coding!

@nstjean

This comment has been minimized.

Copy link
Contributor

@nstjean nstjean commented Nov 30, 2019

Thanks! Looks great! :)

@kushaggarwal

This comment has been minimized.

Copy link

@kushaggarwal kushaggarwal commented Dec 3, 2019

Can I work on this issue

@govindgoel

This comment has been minimized.

Copy link
Member Author

@govindgoel govindgoel commented Dec 3, 2019

assigned @kushaggarwal

@kushaggarwal

This comment has been minimized.

Copy link

@kushaggarwal kushaggarwal commented Dec 5, 2019

In which branch should I post the pull request
Can you help please

@nstjean

This comment has been minimized.

Copy link
Contributor

@nstjean nstjean commented Dec 9, 2019

@kushaggarwal Sorry for the wait! To post a pull request you will go into your forked branch that has the changes and post the pull request from there against the publiclab/master branch.
Here's some info from GitHub on how to do that: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.