Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make footer topics section responsive #7017

Open
VladimirMikulic opened this issue Dec 19, 2019 · 11 comments · May be fixed by #7018
Open

Make footer topics section responsive #7017

VladimirMikulic opened this issue Dec 19, 2019 · 11 comments · May be fixed by #7018

Comments

@VladimirMikulic
Copy link
Contributor

@VladimirMikulic VladimirMikulic commented Dec 19, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

🔥 Problem

Screenshot_20191219_195245

Screenshot_20191219_195354

Screenshot_20191219_195422

The footer topics section looks really bad :(
That's why you are here, right?

Make it responsive 😎

🚩 Goal

Screenshot_20191219_195507

Screenshot_20191219_195553

Screenshot_20191219_195633

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Open plots2/app/assets/stylesheets/style.css
    After the footer ul selector(line 278) add this code:

.footer-topics .row {
    justify-content: space-around;
}

.footer-topics .row .col-md-3 {
    flex-basis: 50%;
    max-width: fit-content;
}

@media(max-width: 768px) {
    .footer-topics .row .col-md-3 {
        max-width: none;
        text-align: center;
    }
}

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@candesign

This comment has been minimized.

Copy link

@candesign candesign commented Dec 20, 2019

I'd like to do this. :)

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Dec 20, 2019

@candesign go for it 🚀

@candesign candesign linked a pull request that will close this issue Dec 20, 2019
5 of 5 tasks complete
@Priyanka-Bnsl

This comment has been minimized.

Copy link

@Priyanka-Bnsl Priyanka-Bnsl commented Dec 20, 2019

can i work on this issue?

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Dec 20, 2019

Hi, @Priyanka-Bnsl. I am glad that you are interested in working with us 🚀
We have a PR for this issue, but if you wish you could help us by fixing this issue

Thanks.

@jywarren

This comment has been minimized.

Copy link
Contributor

@jywarren jywarren commented Dec 20, 2019

@Priyanka-Bnsl Priyanka-Bnsl mentioned this issue Dec 21, 2019
5 of 5 tasks complete
@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Dec 21, 2019

@jywarren could you explain to me what is a database-backed feature?
Where should I find it? Thanks.

@guptaaman70659

This comment has been minimized.

Copy link

@guptaaman70659 guptaaman70659 commented Dec 31, 2019

I am Interested to resolve this issue

@guptaaman70659

This comment has been minimized.

Copy link

@guptaaman70659 guptaaman70659 commented Dec 31, 2019

I have added the code in style.css. and made pull request
If there something I forget please tell me

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Dec 31, 2019

Hi @guptaaman70659. I am glad that you are showing interest in our project.
This issue has already been solved, as you can see we have 2 PRs for it.

You can take a look at other FTOs.

@guptaaman70659

This comment has been minimized.

Copy link

@guptaaman70659 guptaaman70659 commented Jan 1, 2020

Hi @VladimirMikulic
First of all thanks for giving response
I have one doubt why this Issue is opened yet If it has already been solved ?

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Jan 1, 2020

@guptaaman70659 we misunderstood each other. By "solved" I meant that we have 2 PRs that are resolving this issue.

I hope it's clear now :)
Also, Happy New Year 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.