Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the styling of Woofmark buttons on pl.org/post #7067

Closed
VladimirMikulic opened this issue Dec 31, 2019 · 17 comments · Fixed by yihenghuang/plots2#1
Closed

Improve the styling of Woofmark buttons on pl.org/post #7067

VladimirMikulic opened this issue Dec 31, 2019 · 17 comments · Fixed by yihenghuang/plots2#1

Comments

@VladimirMikulic
Copy link
Contributor

@VladimirMikulic VladimirMikulic commented Dec 31, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

🔥 Problem

Screenshot_20191231_234530

Screenshot_20191231_233610

As you can see on the image above, we have some serious issues with our new editor on https://publiclab.org/post. Buttons are overflowing its container, disappearing and causing horizontal scroll bars.
It's even worse on mobile devices and this should be patched ASAP.

🚩 Goal

Screenshot_20200102_233239

Screenshot_20200102_233306

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Open the file plots2/app/assets/stylesheets/style.css

  • Line 342, after the comment, add this code:

@media(max-width: 768px) {
  .ple-module-content {
    display: flex;
    flex-direction: column;
    align-items: center;
  }
  
  .ple-module-content .wk-wysiwyg {
      width: 100%;
  }
    
  .ple-content .wk-commands {
    display: flex;
    justify-content: center;
    flex-wrap: wrap;
    max-width: 390px;
  }

  .ple-content .wk-commands .btn {
    display: flex;
    justify-content: center;
    align-items: center;

    min-width: 50px;
    height: 38px;
    background: white;
    margin: 0px;
    border-radius: 0 !important;
    border: 1px solid #ddd;
    border-left: none;
  }
  
  .ple-content .wk-commands button.btn:nth-of-type(1),
  .ple-content .wk-commands .btn:nth-of-type(8) {
      border-left: 1px solid #ddd;
  }
  
  .ple-content .wk-commands .btn:nth-of-type(8),
  .ple-content .wk-commands .btn:nth-of-type(9),
  .ple-content .wk-commands .btn:nth-of-type(10),
  .ple-content .wk-commands a.btn{
      border-top: 0;
  }

  .ple-content .wk-switchboard {
    text-align: center;
    float: none;
  }
}

@media(max-width: 480px) {
    .ple-content .wk-commands {
        max-width: 325px;
    }
    .ple-content .wk-commands .btn {
        min-width: 30px;
        max-width: 43px;
        width: 100%;
    }
}

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming the first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Dec 31, 2019

@nstjean This FTO is the "second" part of the publiclab/PublicLab.Editor#378 issue. I would like your opinion on this change :)

@yihenghuang

This comment has been minimized.

Copy link

@yihenghuang yihenghuang commented Jan 1, 2020

Hi, can I claim this issue?
I see in issue #378. we hid away some tabs after we took away the bottom scroll bar.

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Jan 1, 2020

@yihenghuang Happy New Year 🎉
The issue is all yours :)

@nstjean

This comment has been minimized.

Copy link
Contributor

@nstjean nstjean commented Jan 1, 2020

@VladimirMikulic Thanks for making these FTOs! This is great! the only thing I'm not sure about is adding in the space between buttons, they may prefer it to look like a toolbar. @cesswairimu maybe you can weigh in?

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Jan 1, 2020

@nstjean thanks, I try to do my best. This is how it looks like without spacing in between.

Screenshot_20200101_163141

Screenshot_20200101_163210

I am not a designer, but the general rule is to allow users to "breathe". It's easier for the eyes.
If you and @cesswairimu prefer toolbar layout, I'll change it 😄

@cesswairimu

This comment has been minimized.

Copy link
Collaborator

@cesswairimu cesswairimu commented Jan 1, 2020

I also think that without spaces gives it the toolbar feel. But I see what @VladimirMikulic you mean with giving the usability being affected...Maybe we could partition it but still have it as whole as it is in PublicEditor samples
Screenshot from 2020-01-02 00-04-04

What do you both think? Thanks all

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Jan 1, 2020

@cesswairimu, unfortunately, we can't have it as a "whole" toolbar. Icons would be very small. Mobile screens are too small for the "whole" toolbar. It needs to be in multiple rows :)

@cesswairimu

This comment has been minimized.

Copy link
Collaborator

@cesswairimu cesswairimu commented Jan 1, 2020

My thinking was to have it as this
71643052-60eb7300-2cb4-11ea-97a2-6e3ec695cb34
but with the partitions like
Screenshot from 2020-01-02 00-04-04
between if possible? What do you think?

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Jan 2, 2020

@cesswairimu it's your call :)
Here are the two possible layouts.

Screenshot_20200102_005902

Screenshot_20200102_005545

Personally I like the first option, but again it's up to you and @nstjean to decide what is better.
You are here longer than I am 😄

@nstjean

This comment has been minimized.

Copy link
Contributor

@nstjean nstjean commented Jan 2, 2020

I like it all together, so the second option. :) What about you @cesswairimu ?

@cesswairimu

This comment has been minimized.

Copy link
Collaborator

@cesswairimu cesswairimu commented Jan 2, 2020

Yeah I agree with @nstjean, the second option looks great.

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Jan 2, 2020

@cesswairimu @nstjean Awesome! Thank you both for your help. The issue is updated accordingly.

@yihenghuang yihenghuang mentioned this issue Jan 12, 2020
0 of 5 tasks complete
@yihenghuang

This comment has been minimized.

Copy link

@yihenghuang yihenghuang commented Jan 12, 2020

@VladimirMikulic Hi sorry for the late feedback. I try to follow your instruction but didnt find any comment at line 342. Please feel free to reject my PR if the code was not inserted at an organized location. Thanks for helping me through my first contribution!

@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Jan 12, 2020

@yihenghuang Apparently someone removed the comment. Your change works fine :)

@developer22-university

This comment has been minimized.

Copy link

@developer22-university developer22-university commented Jan 12, 2020

I am working on this one @VladimirMikulic

developer22-university added a commit to developer22-university/plots2 that referenced this issue Jan 12, 2020
Improve the styling of Woofmark buttons on pl.org/post
developer22-university added a commit to developer22-university/plots2 that referenced this issue Jan 12, 2020
…ity-patch-1

resolved issue publiclab#7067
developer22-university added a commit to developer22-university/plots2 that referenced this issue Jan 12, 2020
developer22-university added a commit to developer22-university/plots2 that referenced this issue Jan 12, 2020
Improve the styling of Woofmark buttons on pl.org/post
@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Jan 12, 2020

@developer22-university sorry. @yihenghuang unexpectedly submitted a PR.
I thought that he had abandoned it so that's why I suggested you to solve this.

If you still want to contribute, try this one publiclab/mapknitter#1193
It's also very important.

Thanks.

developer22-university added a commit to developer22-university/plots2 that referenced this issue Jan 12, 2020
Improve the styling of Woofmark buttons on pl.org/post
developer22-university added a commit to developer22-university/plots2 that referenced this issue Jan 12, 2020
@VladimirMikulic

This comment has been minimized.

Copy link
Contributor Author

@VladimirMikulic VladimirMikulic commented Jan 14, 2020

The issue has been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.