Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map slider on location modal not updating on zoom #7079

Closed
nstjean opened this issue Jan 1, 2020 · 11 comments
Closed

Fix map slider on location modal not updating on zoom #7079

nstjean opened this issue Jan 1, 2020 · 11 comments

Comments

@nstjean
Copy link
Contributor

@nstjean nstjean commented Jan 1, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _form.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Just after this code here:

var slider = $('#ex1').slider()
.on('slide', changeZoom)
.data('slider');

Right after line 111 add this code:

      blurredLocation.map.on('zoomend', function() {
        let zoom = blurredLocation.map.getZoom();
        $('#ex1').slider('setValue', zoom);
      })

This will make the slider respond to when the map zooms in and out!

Peek 2020-01-01 14-48

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@DevchamploO

This comment has been minimized.

Copy link

@DevchamploO DevchamploO commented Jan 1, 2020

Hello. I would like to work on this issue.

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 1, 2020

@DevchamploO OK go ahead!

@sssash18

This comment has been minimized.

Copy link
Contributor

@sssash18 sssash18 commented Jan 8, 2020

@nstjean Can I take up the issue if it has not been completed ?

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 8, 2020

@DevchamploO Are you still working on this? Do you need any help?

@DevchamploO

This comment has been minimized.

Copy link

@DevchamploO DevchamploO commented Jan 8, 2020

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 8, 2020

@DevchamploO Ok, great, thanks! Just wanted to check in! :)

@DevchamploO

This comment has been minimized.

Copy link

@DevchamploO DevchamploO commented Jan 9, 2020

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 9, 2020

I'm not very familiar with install errors, I did a quick search and couldn't find anything that mentions that problem. I'm going to find someone who can help you with that!
In the meantime go through these instructions and make sure you didn't miss a step (because that happened to me when I installed everything!): https://github.com/publiclab/plots2#installation
You can also read through this thread for anything that might help: #3840

@DevchamploO

This comment has been minimized.

Copy link

@DevchamploO DevchamploO commented Jan 15, 2020

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 15, 2020

@DevchamploO I'm sorry you're having problems! It does sound like a PATH issue. :(

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 15, 2020

After looking at the code for this page I believe I accidentally already completed this in #6957 where I was testing it. Oops!

@nstjean nstjean closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.