Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location modal script to dashboard #7266

Open
nstjean opened this issue Jan 16, 2020 · 8 comments
Open

Add location modal script to dashboard #7266

nstjean opened this issue Jan 16, 2020 · 8 comments

Comments

@nstjean
Copy link
Contributor

@nstjean nstjean commented Jan 16, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file sidebar/_dashboard in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

At the end of the file add this line:

<%= render partial: 'tag/location' %>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 16, 2020

Note that this template is required for the location-modal to pop up when the new button is clicked. :)

@9916103020

This comment has been minimized.

Copy link

@9916103020 9916103020 commented Jan 16, 2020

@nstjean can I take this issue?

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 16, 2020

@9916103020 Yes please! Go ahead!

@keshavsethi

This comment has been minimized.

Copy link
Member

@keshavsethi keshavsethi commented Jan 17, 2020

Can I try this if it is still open

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 17, 2020

@keshavsethi Let's let @9916103020 have a chance to complete it. I just posted links to some first time issues that are open: #6579 (comment)

@9916103020

This comment has been minimized.

Copy link

@9916103020 9916103020 commented Jan 18, 2020

@nstjean Could you please tell what pre-requisites for standard installation on my PC?

@9916103020

This comment has been minimized.

Copy link

@9916103020 9916103020 commented Jan 18, 2020

@nstjean is it important to have knowledge of the ruby on rails?

@nstjean

This comment has been minimized.

Copy link
Contributor Author

@nstjean nstjean commented Jan 27, 2020

@9916103020 are you still working on this? I'm sorry I didn't see your question. This can be edited without installing anything. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.