Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the function t to translation in app/views/sidebar/_list.html.erb #7483

Open
govindgoel opened this issue Feb 13, 2020 · 5 comments
Open

Comments

@govindgoel
Copy link
Member

@govindgoel govindgoel commented Feb 13, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file $FILENAME in the $REPO repository (press the little pen Icon) and edit the line as shown below.

Link to file

See this page for some help in taking your first steps!
The function needs to be changes in the following lines:

7. <%= raw t('sidebar._list.mailing_list', :mailing_list => mailing_list, :url1 
12. <%= t('sidebar._list.subscribe') %>
26. <%= t('sidebar._list.all_topics') %>

The changes should look like this in respective lines:

7. <%= raw translation('sidebar._list.mailing_list', :mailing_list => mailing_list, :url1 
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@EvgenyNikolaevich

This comment has been minimized.

Copy link

@EvgenyNikolaevich EvgenyNikolaevich commented Feb 13, 2020

Hello there,
I'll take it, please=)

@EvgenyNikolaevich

This comment has been minimized.

Copy link

@EvgenyNikolaevich EvgenyNikolaevich commented Feb 13, 2020

I'm waiting for permission for pushing=)

@nstjean

This comment has been minimized.

Copy link
Contributor

@nstjean nstjean commented Feb 13, 2020

@EvgenyNikolaevich Go ahead! Thanks!

@EvgenyNikolaevich

This comment has been minimized.

Copy link

@EvgenyNikolaevich EvgenyNikolaevich commented Feb 18, 2020

May be you have some ideas
I still cannot push my branch to upstream.

Pushing to git@github.com:publiclab/plots2.git
ERROR: Permission to publiclab/plots2.git denied to EvgenyNikolaevich.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
@nstjean

This comment has been minimized.

Copy link
Contributor

@nstjean nstjean commented Feb 18, 2020

@EvgenyNikolaevich So what you are going to do is fork this repo to your own account. Then you create a branch in your own fork, and push the changes up with git push origin branch-name. Once it's pushed up to your fork then you can create a pull request so that we can merge it into the publiclab repo. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.