Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining gems added #2686

Merged
merged 1 commit into from May 8, 2018
Merged

Remaining gems added #2686

merged 1 commit into from May 8, 2018

Conversation

SidharthBansal
Copy link
Member

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@SidharthBansal
Copy link
Member Author

SidharthBansal commented May 2, 2018

I will try to send one more pr for the can_tag implementation in the user_tag controller before my end sems ends.
I have my end semester exams till 19th may. So, I will not be able to work much till 19.

@PublicLabBot
Copy link

2 Messages
📖 @SidharthBansal Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@jywarren
Copy link
Member

jywarren commented May 2, 2018

Good luck on your end sem exams!! If I could get a review from @publiclab/reviewers I'd love to merge this in -- thanks, all!

@jywarren jywarren requested a review from a team May 8, 2018 17:06
Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me !

gem 'omniauth-google-oauth2'
gem 'omniauth-twitter'
gem 'omniauth-github', '~> 1.1', '>= 1.1.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SidharthBansal , could you point to Planning issue of your project ?

@jywarren jywarren merged commit 0647cb0 into master May 8, 2018
@jywarren
Copy link
Member

jywarren commented May 8, 2018

Awesome!!!! Thanks both of you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants