New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeClimate documentation #3068

Merged
merged 2 commits into from Jul 17, 2018

Conversation

Projects
5 participants
@stefannibrasil
Collaborator

stefannibrasil commented Jul 15, 2018

@jywarren what do you think about this? is it okay to add the images on that folder? Thanks!

@plotsbot

This comment has been minimized.

Collaborator

plotsbot commented Jul 15, 2018

2 Messages
📖 @stefannibrasil Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@milaaraujo milaaraujo added the rgsoc label Jul 15, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jul 15, 2018

It looks great but I think we can make a folder like /doc/images/ - how's that sound? Thanks!!!

@sagarpreet-chadha

Small change by @jywarren and then looks good to go 😄 !

@stefannibrasil stefannibrasil force-pushed the milaaraujo:add-codeclimate-doc branch from 13ded84 to 42ebe12 Jul 17, 2018

@stefannibrasil

This comment has been minimized.

Collaborator

stefannibrasil commented Jul 17, 2018

@sagarpreet-chadha @jywarren yep, that makes more sense! folders updated, thanks for the help!

@milaaraujo milaaraujo added this to In progress in RGSoC 2018 Jul 17, 2018

@milaaraujo milaaraujo self-assigned this Jul 17, 2018

@jywarren jywarren merged commit 362e178 into publiclab:master Jul 17, 2018

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Well done.
Details

RGSoC 2018 automation moved this from In progress to Done Jul 17, 2018

@wafflebot wafflebot bot removed the in progress label Jul 17, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jul 17, 2018

Awesome, thank you!!!

@stefannibrasil stefannibrasil deleted the milaaraujo:add-codeclimate-doc branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment