New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor typeahead service #3107

Merged
merged 2 commits into from Jul 20, 2018

Conversation

Projects
None yet
4 participants
@stefannibrasil
Collaborator

stefannibrasil commented Jul 20, 2018

As part of #3070 (Refactor Search API) we are opening this PR to remove API Typeahead endpoints duplication. The changes are prety similar to what we did here, but this time we worked on Typeahead endpoints.

Again, we decided to first try to remove some duplications/refactor the code and later improve the searches.

We would like some feedback about our work here, please! :)

@publiclab/reviewers @publiclab/soc @jywarren

@wafflebot wafflebot bot added the in progress label Jul 20, 2018

@stefannibrasil stefannibrasil force-pushed the milaaraujo:typeahead-refactor branch 2 times, most recently from a7665af to c274275 Jul 20, 2018

@stefannibrasil stefannibrasil force-pushed the milaaraujo:typeahead-refactor branch from c274275 to 0fb11a1 Jul 20, 2018

@stefannibrasil stefannibrasil referenced this pull request Jul 20, 2018

Closed

Refactor Search API #3070

3 of 3 tasks complete
@plotsbot

This comment has been minimized.

Collaborator

plotsbot commented Jul 20, 2018

1 Message
📖 @stefannibrasil Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@milaaraujo milaaraujo closed this Jul 20, 2018

@wafflebot wafflebot bot removed the in progress label Jul 20, 2018

@milaaraujo milaaraujo reopened this Jul 20, 2018

@milaaraujo milaaraujo closed this Jul 20, 2018

@wafflebot wafflebot bot removed the review-me label Jul 20, 2018

@milaaraujo milaaraujo reopened this Jul 20, 2018

@wafflebot wafflebot bot added the in progress label Jul 20, 2018

@stefannibrasil

This comment has been minimized.

Collaborator

stefannibrasil commented Jul 20, 2018

@milaaraujo

This comment has been minimized.

Collaborator

milaaraujo commented Jul 20, 2018

Problem solved! All checks have passed! 😃

@publiclab/reviewers @jywarren

srchParams: {
srchString: @sprofile,
seq: @sseq
srchString: 'Jeff',

This comment has been minimized.

@jywarren

jywarren Jul 20, 2018

Contributor

So much better/more readable!!

end
test 'typeahead notes functionality' do
get '/api/typeahead/notes?srchString=lat&seq=7'
get '/api/typeahead/notes?srchString=Blog'

This comment has been minimized.

@jywarren

jywarren Jul 20, 2018

Contributor

Nice, a more realistic and readable API call too...

@jywarren jywarren merged commit 59152d0 into publiclab:master Jul 20, 2018

3 checks passed

codeclimate 6 fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Woo!
Details

@wafflebot wafflebot bot removed the in progress label Jul 20, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Jul 20, 2018

🎉 fantastic!!!

@stefannibrasil stefannibrasil deleted the milaaraujo:typeahead-refactor branch Jul 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment