New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema-rb-example file for SQLite #3242

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
4 participants
@stefannibrasil
Collaborator

stefannibrasil commented Aug 21, 2018

@milaaraujo and I have found an error today on the schema-example.rb file.

When we were trying to understand what was happening with the Travis error on #3134, we tried several things to connect the app with MySQL and that might have caused it... and since I haven't updated my project to use SQLite, I didn't see the error before.

We realized today that it created a schema.rb that only works with MySQL and that was pushed to the master... So this PR fix this. It also fixes an error caused that only happens on SQLite (which we didn't find before because we are using MySQL from now on and Travis as well).

We hope this didn't cause much trouble, but it's really tricky to catch all these things.

Thanks!

@plotsbot

This comment has been minimized.

Collaborator

plotsbot commented Aug 21, 2018

1 Message
📖 @stefannibrasil Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@stefannibrasil stefannibrasil added this to In progress in RGSoC 2018 Aug 21, 2018

@stefannibrasil

This comment has been minimized.

Collaborator

stefannibrasil commented Aug 21, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Aug 21, 2018

Ah, ok - great. Can you resolve the conflicts here and rebase if needed, and then try git push -f https://github.com/publiclab/plots2.git HEAD:unstable or git push -f git@github.com:publiclab/plots2.git HEAD:unstable to push this onto the experimental unstable branch and test it out at https://unstable.publiclab.org to be sure it works in the exact production environment. @icarito can also help if unstable gets stuck so do reach out to him in that case.

Thanks!

@stefannibrasil stefannibrasil moved this from In progress to Being reviewed in RGSoC 2018 Aug 22, 2018

@stefannibrasil stefannibrasil force-pushed the milaaraujo:fix-bug-on-schema-example-file branch from b1c17ca to 1cfe98c Aug 22, 2018

@stefannibrasil

This comment has been minimized.

Collaborator

stefannibrasil commented Aug 22, 2018

hi @jywarren, @icarito helped me and the https://unstable.publiclab.org is running with this commit. I believe this is ready to merge when you approve? Thanks!

@stefannibrasil stefannibrasil added ready and removed review-me labels Aug 22, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Aug 27, 2018

Great, thanks! Perhaps related to fully switching to mariadb, we had thought of the possibility of adding a second run of tests that run everything in sqlite... good to consider in #3170

@jywarren jywarren merged commit 066efe5 into publiclab:master Aug 27, 2018

6 checks passed

ci/gitlab/unstable Pipeline passed on GitLab
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at ?%
Details
danger/danger All green. Woo!
Details

RGSoC 2018 automation moved this from Being reviewed to Done Aug 27, 2018

@wafflebot wafflebot bot removed the ready label Aug 27, 2018

@stefannibrasil stefannibrasil deleted the milaaraujo:fix-bug-on-schema-example-file branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment