New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test to the SearchService class methods #3251

Merged
merged 2 commits into from Aug 28, 2018

Conversation

Projects
None yet
4 participants
@milaaraujo
Collaborator

milaaraujo commented Aug 22, 2018

Hey everybody!

We are opening this request to fix the issue #3249.

We added unit tests for SearchService class methods.

We would like some feedback, thanks! :)

fixes #3249
@publiclab/reviewers @publiclab/soc @jywarren

@plotsbot

This comment has been minimized.

Collaborator

plotsbot commented Aug 22, 2018

1 Message
📖 @milaaraujo Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@milaaraujo milaaraujo requested a review from jywarren Aug 23, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Aug 28, 2018

This looks really good. Looks like it needs a rebase and we can go ahead! Thanks!

@stefannibrasil stefannibrasil force-pushed the milaaraujo:add-unit-test-to-search-api branch from 6324de0 to 4890968 Aug 28, 2018

@stefannibrasil

This comment has been minimized.

Collaborator

stefannibrasil commented Aug 28, 2018

@jywarren done!

@stefannibrasil stefannibrasil added ready and removed review-me labels Aug 28, 2018

@jywarren jywarren merged commit d9bbfad into publiclab:master Aug 28, 2018

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Nice work.
Details

@wafflebot wafflebot bot removed the ready label Aug 28, 2018

@jywarren

This comment has been minimized.

Contributor

jywarren commented Aug 28, 2018

Beautiful! Thanks.

@milaaraujo milaaraujo deleted the milaaraujo:add-unit-test-to-search-api branch Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment