Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API params to ruby standard #3519

Merged
merged 2 commits into from Sep 27, 2018

Conversation

Projects
4 participants
@stefannibrasil
Copy link
Collaborator

stefannibrasil commented Sep 27, 2018

After writing the #3508 API docs yesterday, we noticed that we could rename some params from the API so they use the Ruby naming convention. And also, srchString was not a good name because some params aren't a string and that could lead to some confusion in the future.

We searched through the whole app to change the API calls. But we were wondering if other repositories also use the API? @jywarren

@wafflebot wafflebot bot added the in progress label Sep 27, 2018

@stefannibrasil stefannibrasil force-pushed the milaaraujo:rename-api-params-to-ruby-standard branch from 433f3f7 to a16ec11 Sep 27, 2018

@plotsbot

This comment has been minimized.

Copy link
Collaborator

plotsbot commented Sep 27, 2018

1 Message
📖 @stefannibrasil Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@stefannibrasil stefannibrasil added this to In progress in RGSoC 2018 Sep 27, 2018

@stefannibrasil stefannibrasil force-pushed the milaaraujo:rename-api-params-to-ruby-standard branch from 8955740 to e79689f Sep 27, 2018

@jywarren jywarren merged commit 542716d into publiclab:master Sep 27, 2018

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Jolly good show.
Details

RGSoC 2018 automation moved this from In progress to Done Sep 27, 2018

@wafflebot wafflebot bot removed the in progress label Sep 27, 2018

@jywarren

This comment has been minimized.

Copy link
Contributor

jywarren commented Sep 27, 2018

🎉🤯😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.