Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dupe link to wiki on notes page #5653

Merged
merged 1 commit into from May 20, 2019

Conversation

@becomingajunior
Copy link
Contributor

commented May 3, 2019

Fixes #5547

Details on issue: on the notes page, there is a wiki page tab alongside the popular/liked tabs and also, a link on the side bar which says "Browse the Public Lab wiki". Both of them correspond to the wiki page. Therefore, remove the Wiki pages tab by removing lines 33-35.

Lines 33 - 35 removed!

✔️ PR is descriptively titled 📑 and links the original issue above 🔗
✔️ tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
✔️ code is in uniquely-named feature branch and has no merge conflicts 📁
✔️ screenshots/GIFs are attached 📎 in case of UI updation
Screen Shot 2019-05-02 at 7 24 58 PM

✔️ ask @publiclab/reviewers for help, in a comment below

Thank you!

@welcome

This comment has been minimized.

Copy link

commented May 3, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@becomingajunior

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@publiclab/reviewers - this is my first pull request, I'd love any feedback you could give me. Thanks!

@plotsbot

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

2 Messages
📖 @becomingajunior Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@becomingajunior

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

2 Messages
📖 @becomingajunior Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.
Generated by 🚫 Danger

Thanks! I wasn't sure how to make the check marks, HA. I've copied and pasted the ✔️ from the text above, I hope that works! If not, please let me know how to make the actual checkmarks.

@CoderJolly

This comment has been minimized.

Copy link
Member

commented May 9, 2019

@gauravano pls merge this PR, it looks fine

@jywarren jywarren merged commit 88032b1 into publiclab:master May 20, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Jolly good show.
Details
@welcome

This comment has been minimized.

Copy link

commented May 20, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Thanks!!!

@becomingajunior

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@gauravano

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Also @becomingajunior, we would love to have more help from you. If you are interested in solving more issues then, check here - https://code.publiclab.org/#r=all for a new issue. In case, you are unable to find an issue, feel free to comment below. Thanks!

@becomingajunior

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

Thanks @gauravano, I'd love to work on more issues. I'll take a look for sure and let you know if I can't find anything.

@gauravano

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.