New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix map position to above in mobile responsiveness #5754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CleverFool77
changed the title
Fix map position in mobile responsiveness
Fix map position to above in mobile responsiveness
May 21, 2019
CleverFool77
added
design
issue requires more design work and discussion (i.e. mockups and sketches)
outreachy
summer-of-code
labels
May 21, 2019
Generated by 🚫 Danger |
Hi @jywarren After fixing the horizontal cards , we can go for this PR. |
sagarpreet-chadha
approved these changes
May 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome use of CSS :-)
awesome, ready for review/merge here? Thanks!!!
…On Tue, May 21, 2019 at 7:46 AM Lekhika Dugtal ***@***.***> wrote:
Fixes #5707 <#5707> part (<===
Add issue number here)
[image: abovemap]
<https://user-images.githubusercontent.com/26685258/58093414-1a954800-7bec-11e9-919f-573c98ef14a2.gif>
- PR is descriptively titled 📑 and links the original issue above 🔗
- tests pass -- look for a green checkbox ✔️ a few minutes after
opening your PR -- or run tests locally with rake test
- code is in uniquely-named feature branch and has no merge conflicts
📁
- screenshots/GIFs are attached 📎 in case of UI updation
- ask @publiclab/reviewers for help, in a comment below
------------------------------
You can view, comment on, or merge this pull request online at:
#5754
Commit Summary
- Fix map position in mobile responsiveness
File Changes
- *M* app/views/users/list.html.erb
<https://github.com/publiclab/plots2/pull/5754/files#diff-0> (6)
Patch Links:
- https://github.com/publiclab/plots2/pull/5754.patch
- https://github.com/publiclab/plots2/pull/5754.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5754?email_source=notifications&email_token=AAAF6J3AT7CCHPWOSWZMCADPWPOINA5CNFSM4HOKEYH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GU6FE5A>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J7Q26RPSGQGSG2N5T3PWPOINANCNFSM4HOKEYHQ>
.
|
Hi @jywarren This is ready for merge. |
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
issue requires more design work and discussion (i.e. mockups and sketches)
outreachy
summer-of-code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5707 part (<=== Add issue number here)
rake test
@publiclab/reviewers
for help, in a comment below