Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map position to above in mobile responsiveness #5754

Merged
merged 2 commits into from May 21, 2019

Conversation

@CleverFool77
Copy link
Member

commented May 21, 2019

Fixes #5707 part (<=== Add issue number here)

abovemap

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@CleverFool77 CleverFool77 changed the title Fix map position in mobile responsiveness Fix map position to above in mobile responsiveness May 21, 2019

@plotsbot

This comment has been minimized.

Copy link
Collaborator

commented May 21, 2019

1 Warning
鈿狅笍 It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits 鈥 you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
2 Messages
馃摉 @CleverFool77 Thank you for your pull request! I鈥檓 here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don鈥檛 be discouraged if you see errors 鈥 we鈥檙e here to help.
馃摉 This pull request doesn鈥檛 link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 馃毇 Danger

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

Hi @jywarren After fixing the horizontal cards , we can go for this PR.
Thanks !!!

@sagarpreet-chadha
Copy link
Contributor

left a comment

Awesome use of CSS :-)

@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

Hi @jywarren This is ready for merge.
thanks !!!!

@jywarren jywarren merged commit 439d3ce into publiclab:master May 21, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger 鈿狅笍 1 Warning. Don't worry, everything is fixable.
Details
@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can鈥檛 perform that action at this time.