Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map position to above in mobile responsiveness #5754

Merged
merged 2 commits into from May 21, 2019

Conversation

CleverFool77
Copy link
Member

Fixes #5707 part (<=== Add issue number here)

abovemap

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@CleverFool77 CleverFool77 changed the title Fix map position in mobile responsiveness Fix map position to above in mobile responsiveness May 21, 2019
@CleverFool77 CleverFool77 added design issue requires more design work and discussion (i.e. mockups and sketches) outreachy summer-of-code labels May 21, 2019
@plotsbot
Copy link
Collaborator

plotsbot commented May 21, 2019

1 Warning
⚠️ It looks like you merged from master in this pull request. Please rebase to get rid of the merge commits – you may want to rewind the master branch and rebase instead of merging in from master, which can cause problems when accepting new code!
2 Messages
📖 @CleverFool77 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 🚫 Danger

@CleverFool77
Copy link
Member Author

Hi @jywarren After fixing the horizontal cards , we can go for this PR.
Thanks !!!

Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome use of CSS :-)

@jywarren
Copy link
Member

jywarren commented May 21, 2019 via email

@CleverFool77
Copy link
Member Author

Hi @jywarren This is ready for merge.
thanks !!!!

@jywarren jywarren merged commit 439d3ce into publiclab:master May 21, 2019
@jywarren
Copy link
Member

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design issue requires more design work and discussion (i.e. mockups and sketches) outreachy summer-of-code
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

UI Improvements Planning Issue : People Section
4 participants