Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sidebar `Share your button` dropdown-menu position with bootstrap4 #5755

Merged
merged 1 commit into from May 21, 2019

Conversation

@CleverFool77
Copy link
Member

commented May 21, 2019

Fixes #5612

Screenshot from 2019-05-21 17-37-41

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below
@plotsbot

This comment has been minimized.

Copy link
Collaborator

commented May 21, 2019

2 Messages
馃摉 @CleverFool77 Thank you for your pull request! I鈥檓 here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don鈥檛 be discouraged if you see errors 鈥 we鈥檙e here to help.
馃摉 This pull request doesn鈥檛 link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.

Generated by 馃毇 Danger

@CleverFool77 CleverFool77 force-pushed the CleverFool77:shareyourwork-position branch from 7a01c4e to 8b4a82f May 21, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Awesome!!!

@jywarren jywarren merged commit 29281ff into publiclab:master May 21, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Yay.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.