Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cards for tags section #5766

Merged
merged 1 commit into from May 23, 2019

Conversation

@CleverFool77
Copy link
Member

commented May 22, 2019

Fixes #5675

gg

Note with Image

Screenshot from 2019-05-23 17-02-45

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below
@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:cards-tags branch from 176b72a to fb78901 May 23, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

Looks great! Can you try with a profile picture to be sure that formats nicely? Awesome!!!!!

Hi @jywarren
Just fixed the image bug.
This Pr is ready I guess
Thanks !!!

@jywarren jywarren merged commit 4be7914 into publiclab:master May 23, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Awesome!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can鈥檛 perform that action at this time.