Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment in subscriptions #5767

Merged
merged 1 commit into from May 30, 2019

Conversation

@CleverFool77
Copy link
Member

commented May 22, 2019

Fixes #5612

Earlier

Screenshot from 2019-05-22 19-16-42

After Changes : Desktop

Screenshot from 2019-05-22 19-16-06

After changes : Mobile

Screenshot from 2019-05-22 19-16-31

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Aha! This failed due to system tests -- @gautamig54 just had this happen too, i think.

See how only one test run failed, but the other succeeded?

image

I've restarted them! Hopefully this works, but we may need to re-open #5683 ...

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Hi @jywarren yes it worked.
Now all the checks has passed.
Thanks !!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Awesome!!!!!

@jywarren jywarren merged commit 8ca4b78 into publiclab:master May 30, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Great work!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.