Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first section for shadow question page #5787

Merged

Conversation

@CleverFool77
Copy link
Member

commented May 24, 2019

Fixes #5733 part

  • Added a shadow route
  • Added first section

Screenshot from 2019-05-24 13-29-03

The screen appears darker due to screenshot but In real, it isn't.

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below
@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

Hi @jywarren I started off with questions page first section in shadow route.
Thanks !!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

Looks good - ready to merge, do you think? Great work!

I guess this is ready for merge.
Thanks !!

@gautamig54

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Looks great @CleverFool77. This is ready for merge @jywarren.

@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Awesome! Thanks for the review, too, @gautamig54 ! Very helpful to make final review and merge quicker. 馃檶

@jywarren

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Also you can always ask for more reviews in the chatroom! https://gitter.im/publiclab/publiclab

@jywarren jywarren merged commit 0ab90c6 into publiclab:master May 29, 2019

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

UI improvements - Summer Of Code 2019 automation moved this from In progress to Done May 29, 2019

@gautamig54 gautamig54 referenced this pull request May 29, 2019
4 of 5 tasks complete

@CleverFool77 CleverFool77 deleted the CleverFool77:questions-page-first-section branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can鈥檛 perform that action at this time.