Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side vertical nav tab and dropdown menu for search by results #5851

Merged
merged 1 commit into from Jun 6, 2019

Conversation

@CleverFool77
Copy link
Member

commented Jun 6, 2019

Fixes #5708 part

side

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@CleverFool77 CleverFool77 requested review from jywarren and ebarry Jun 6, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2019

Hi @jywarren @ebarry just pushed the latest changes as discussed in the Issue.
I'll go for google search next.
thanks !!!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Nice!!! Great work!

@jywarren jywarren merged commit 8bb4c7a into publiclab:master Jun 6, 2019

2 checks passed

codeclimate Approved by Jeffrey Warren.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

UI improvements - Summer Of Code 2019 automation moved this from In progress to Done Jun 6, 2019

@CleverFool77 CleverFool77 deleted the CleverFool77:side-vertical-tab branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can鈥檛 perform that action at this time.