Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual Page: Add new redesigned cards and change the test #5948

Merged
merged 3 commits into from Jul 5, 2019

Conversation

@CleverFool77
Copy link
Member

commented Jun 25, 2019

Fixes #5890 part

New notes cards

Screenshot from 2019-06-28 16-43-05

New Question cards

Screenshot from 2019-06-28 17-34-37

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

HI @jywarren I noticed that we have new design for notes. But what's the new design for question cards ?

@CleverFool77 CleverFool77 force-pushed the CleverFool77:new_card branch from b28a97a to 0c45e76 Jun 26, 2019

@CleverFool77 CleverFool77 added review-me and removed in-progress labels Jun 26, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:new_card branch from 0c45e76 to a84d6ba Jun 26, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

HI @gautamig54 @jywarren Just pushed the cards design changes.
Thanks !!

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

This change had done changes in profile page too for now.
Should I let it remain like this ? or make new file for tags page. Though we will be changing the UI of profile page next , so it doesn't matter much according to me.
Screenshot from 2019-06-26 21-06-00

@CleverFool77 CleverFool77 force-pushed the CleverFool77:new_card branch from a84d6ba to efbd3c8 Jun 26, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

I provided background grey to deal with various sizes of images.
Hi @jywarren Should we add a feature of cropping image by user according to size required by this platform while uploading it ?
Then we don't have to deal with various fixes of images everywhere due to sizes.

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

@CleverFool77 CleverFool77 changed the title [WIP] Individual Page: Add new redesigned cards Individual Page: Add new redesigned cards Jun 26, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

Hi !!!
So Should I follow what we are currently following in dashboard or should I follow what I've updated in this PR ?
And regarding second part I'll go through the mockups and will work on questions cards next then.
Thanks !!!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:new_card branch from efbd3c8 to d9f7248 Jun 28, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

I just pushed some changes for notes card.

Screenshot from 2019-06-28 14-26-17

@CleverFool77 CleverFool77 force-pushed the CleverFool77:new_card branch 2 times, most recently from a8e88f2 to c20b2a3 Jun 28, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

I just pushed another set of changes.
Thanks !!

Screenshot from 2019-06-28 15-42-58

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Just pushed
Screenshot from 2019-06-28 16-43-05

@CleverFool77 CleverFool77 force-pushed the CleverFool77:new_card branch 2 times, most recently from c67ff82 to 8d31f0e Jun 28, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Hi @jywarren
I went through public style guide and didn't found the design for Question card.
So for now I've done this update.
Screenshot attached

Screenshot from 2019-06-28 17-34-37

@gautamig54 Do you know the design for new question card ? OR @jywarren do we have to follow what gautami would be doing in recent question design ?

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

Hi! The questions design wasn't very clear so I made the title include it:

image

Many questions don't have images. But maybe it's OK, shall we see how it looks?

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

But i think ideally we'd use the same template, is that OK?

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Hi!!! @jywarren I remember that in question form, we don't have specific field to upload the image ?
Do you mean the image uploaded in information of question is taken ?

Screenshot from 2019-06-28 23-07-02

I noticed another thing, when we try to the question, we have question form but we edit it after posting the question, at that time we have notes form. Is this specifically done ?

question

screenshot attached

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

Aha, again it's looking for a "Spam" button and not finding it:

https://github.com/CleverFool77/plots2/blob/73e50285a460da9241e5f960872bdeb65fd6aaba/test/functional/notes_controller_test.rb#L367-L378

I think you'll need to update this test too!

Hi @jywarren I have done the changes using class gg to find the spam. And Yes it worked locally. But not here on travis.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

Hi @jywarren @gautamig54 The tests passed locally but not on travis ci.
What could be the reason ? Am I missing something ?

gg

gif attached

This is the one.

@CleverFool77 CleverFool77 force-pushed the CleverFool77:new_card branch 3 times, most recently from b3a8b6c to da46ee1 Jul 4, 2019

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Jul 4, 2019

@CleverFool77 CleverFool77 reopened this Jul 4, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Jul 4, 2019

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Jul 4, 2019

@CleverFool77 CleverFool77 reopened this Jul 4, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Jul 4, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:new_card branch from da46ee1 to 8e4c8bb Jul 4, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

Hm, you may need to rebase if it's being inconsistent... Otherwise I can't think of a way it'd be different. Is it the very same error about "gg"?

Yes. In my last commit, I rebased and pushed it again. And checked it locally too. It again passed locally but not travis even after rebase.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

yes it's same error.

@CleverFool77 CleverFool77 force-pushed the CleverFool77:new_card branch from 8e4c8bb to 5a788aa Jul 4, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

Hi @jywarren
Earlier I was running single file only. So Maybe it didn't run locally at all. Now went for running whole folder. So Yeah error got reproduced.
idk why but CSS selectors like class doesn't seem to work in assert select here. And Can't use Ids as it's inside the loop and id need to be unique. To make id unique, it might lead to additional code for this. So I used custom attribute and added it in HTML file. And Now I'm checking for this custom attribute in test.
The custom attribute here data-test="spam"
which is checked in test using assert_select 'a[data-test="spam"]' , 'Spam'

And Now all the checks have passed 🎉 🎉 🎈

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

OK, awesome -- i've found assert_select to be a bit odd at times. So, i'm glad you found a creative solution!

@jywarren jywarren merged commit 9637324 into publiclab:master Jul 5, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Well done.

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Jul 5, 2019

enviro3 added a commit to enviro3/plots2 that referenced this pull request Aug 15, 2019
Individual Page: Add new redesigned cards and change the test (public…
…lab#5948)

* add new notes card

* add new question cards

* change test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.