Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building profile page as per new style guide #5990

Merged
merged 4 commits into from Jul 26, 2019

Conversation

@CleverFool77
Copy link
Member

commented Jul 6, 2019

Fixes #5891 part

  • Change column span and bring map to right
  • Add topic cards for profile page
  • Add information in right column
@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

HI Jeff !!!
before merging this I guess we have to wait till we have another PR for notes card as right now decreasing the first column had made them way too smaller.

Screenshot from 2019-07-06 18-04-43

@CleverFool77 CleverFool77 changed the title Profile page : Chnage col spans and bring map to top-left Profile page : Change col spans and bring map to top-left Jul 6, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

Looks awesome. Shall we build on this before merging? Thanks! You can actually open pull requests against this branch and we can group them (merge them into each other) before merging to master!

This is possible ? Like merging PRs together ?

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2019

yes!!
Even I wanted to say the same that we'll build this profile page first before merging them altogether.
Thanks !!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile branch from 99c374c to 5d0165c Jul 23, 2019

@CleverFool77 CleverFool77 changed the title Profile page : Change col spans and bring map to top-left Building profile page as per new style guide Jul 23, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

Hi @jywarren I wasn't able to understand that how we are suppose to make a new PR against a same branch. Instead I have added code for new topic cards for profile page in this PR only with a different commit.
Below is the gif:

topiccard

cc: @gautamig54

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

Hi @gautamig54 Can We take this PR as main PR for building the profile page and open the PR against this branch called profile with different commit.
What do you say ?

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile branch from 5d0165c to 6b886ce Jul 23, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

Hi @gautamig54 @jywarren On what basis, do we want topic cards to be shown ? For now I've shown all the topic cards but we do have to filter them right !! So Is it based on no of notes ?

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

For now, I would commit all the parts of profile page in this PR instead of making new PR every time.
Is there any suggestions regarding topic cards that I have added for now ?
cc: @gautamig54 @jywarren

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile branch from 6b886ce to 7753482 Jul 25, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Hi @jywarren ust pushed another change for info being shown in left sidebar.
Thanks !!
ss attached:
Screenshot from 2019-07-25 19-00-01

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Hi @jywarren I'll do some more fixes for test and then lets merge it.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Awesome !! All test cases passed.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Should I make the tags in right sidebar directly over left column above topic cards ? As they are chosen by user itself. or should I pick up most used tags for it ? 🤔

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Hi @jywarren This PR is ready, Regarding further changes in profile section. Those will be followed up in next PR.
Thanks !!!

@jywarren jywarren merged commit f9f0bdc into publiclab:master Jul 26, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Nice work.

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Jul 26, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

Awesome!!! Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.