Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Building profile page as per new style guide #5990
Looks awesome. Shall we build on this before merging? Thanks! You can actually open pull requests against this branch and we can group them (merge them into each other) before merging to master!…
On Sat, Jul 6, 2019, 8:33 AM Lekhika Dugtal ***@***.***> wrote: Fixes #5891 <#5891> with location [image: Screenshot from 2019-07-06 17-56-13] <https://user-images.githubusercontent.com/26685258/60756186-3deb4980-a018-11e9-8757-54670eca4a5b.png> without location [image: Screenshot from 2019-07-06 17-59-50] <https://user-images.githubusercontent.com/26685258/60756189-42176700-a018-11e9-9696-529646b1a834.png> ------------------------------ You can view, comment on, or merge this pull request online at: #5990 Commit Summary - Profile page : Chnage col spans and bring map to top-left File Changes - *M* app/views/map/_userLeaflet.html.erb <https://github.com/publiclab/plots2/pull/5990/files#diff-0> (6) - *M* app/views/users/profile.html.erb <https://github.com/publiclab/plots2/pull/5990/files#diff-1> (23) Patch Links: - https://github.com/publiclab/plots2/pull/5990.patch - https://github.com/publiclab/plots2/pull/5990.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5990?email_source=notifications&email_token=AAAF6JZ2LBJZYXEQEZX5OV3P6CGHHA5CNFSM4H6TKOY2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G5VBTWQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J4GEQZPO4E7U47WS6LP6CGHHANCNFSM4H6TKOYQ> .
Yes, it is possible - you can determine which branch you want a PR to be opened against, and you can select a branch that is a second PR, actually! Then they merge together, but the final PR is against the master branch. Make sense?…
On Sat, Jul 6, 2019 at 8:45 AM Lekhika Dugtal ***@***.***> wrote: yes!! Even I wanted to say the same that we'll build this profile page first before merging them altogether. Thanks !! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5990?email_source=notifications&email_token=AAAF6J3ZFHP7RJVLCIR32NTP6CHTZA5CNFSM4H6TKOY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKY7VI#issuecomment-508923861>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J4TND7BVBICGEUQDDDP6CHTZANCNFSM4H6TKOYQ> .
Jul 26, 2019
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.