Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile page: Add tags,edit option and ellipsis for extra info button with in sidebar #6079

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@CleverFool77
Copy link
Member

commented Jul 29, 2019

Fixes #5891

Screenshot from 2019-07-29 15-38-20

profiles-debar

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

Hi @jywarren This PR seems ready, Though I'll adding refinements to sidebar including information after toggle show in next PR. Should this be merged ? or something else is still left for now ?

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Hi @gauravano This PR is ready for review.
Thanks !!

@CleverFool77 CleverFool77 requested review from gauravano and gautamig54 Aug 1, 2019

@gauravano
Copy link
Member

left a comment

Also, can you please change the design of access token and test digest button, use same design as other? -

Screenshot from 2019-08-02 00-40-15

@gauravano

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Great work @CleverFool77 🎉. Just some minor changes.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Also, can you please change the design of access token and test digest button, use same design as other? -

Screenshot from 2019-08-02 00-40-15

Hi @gauravano I'll do the changes you mentioned above but I'm not sure about this change. As this design was already there in the previous design. That specific color different from others being given to some buttons.

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile-sidebar branch from 482ca95 to 8915853 Aug 2, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Hi @gauravano I just updated the changes in PR you have mentioned in review.
Thanks !!!

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Aug 2, 2019

@CleverFool77 CleverFool77 reopened this Aug 2, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Aug 2, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Build failed 🤔. What happened to travis. Its happening again and again.

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Aug 2, 2019

@CleverFool77 CleverFool77 reopened this Aug 2, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Aug 2, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile-sidebar branch 2 times, most recently from 0a768a0 to cac7dfb Aug 3, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile-sidebar branch from cac7dfb to 95c1abd Aug 3, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

Hi @jywarren @gauravano , I was waiting for one of the PR to get merged. Now that PR for shifting of username is merged. So I have updated the latest changes in this PR.
Screenshot attached -
Screenshot from 2019-08-03 12-36-15

Regarding the Info of user , that is posted, commented stuff in second column. Do You want it to centre aligned or from left ?

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

Center looks good! Although we dont specify in style guide. I could go either way.

So all that's left here is the chromedriver issue were working on? Nothing else in system tests is failing? Thanks!

@gauravano

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

@CleverFool77 please rebase your PR.

And, regarding

Hi @gauravano I'll do the changes you mentioned above but I'm not sure about this change. As this design was already there in the previous design. That specific color different from others being given to some buttons.

yeah, I know, but, we want to have consistent design for all buttons so just asked as you were changing code in the same file. Maybe FTO can be opened for this issue?

Thanks!

@gauravano gauravano added ready and removed review-me labels Aug 3, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2019

@CleverFool77 please rebase your PR.

And, regarding

Hi @gauravano I'll do the changes you mentioned above but I'm not sure about this change. As this design was already there in the previous design. That specific color different from others being given to some buttons.

yeah, I know, but, we want to have consistent design for all buttons so just asked as you were changing code in the same file. Maybe FTO can be opened for this issue?

Thanks!

Hi @gauravano

@CleverFool77 please rebase your PR.

And, regarding

Hi @gauravano I'll do the changes you mentioned above but I'm not sure about this change. As this design was already there in the previous design. That specific color different from others being given to some buttons.

yeah, I know, but, we want to have consistent design for all buttons so just asked as you were changing code in the same file. Maybe FTO can be opened for this issue?

Thanks!

Ohkk Cool !! lets discuss with others and after that I'll open a First-timers only issue for it.
Thanks !!

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile-sidebar branch from 95c1abd to c743772 Aug 4, 2019

@plotsbot

This comment has been minimized.

Copy link
Collaborator

commented Aug 4, 2019

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
3 Messages
📖 @CleverFool77 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.
📖 #
Screenshots 📸 (click to expand)

6079-test_viewing_question_post.png

6079-test_wiki.png

6079-test_tag_page.png

6079-test_blog_page_with_location_modal.png

6079-test_login.png

6079-test_wiki_page_with_inline_grids.png

6079-test_questions.png

6079-test_methods.png

6079-test_tag_by_author_page.png

6079-test_viewing_the_dropdown_menu.png

6079-test_comments.png

6079-test_stats.png

6079-test_tags.png

6079-test_people.png

6079-test_front.png

6079-test_signup.png

6079-test_questions_shadow.png

6079-test_blog.png

6079-test_question_page.png

6079-test_front_page_with_navbar_search_autocomplete.png

6079-test_viewing_the_dashboard.png

Learn about automated screenshots

Generated by 🚫 Danger

@gauravano

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Hey @CleverFool77, how about justifying the tags:

Screenshot from 2019-08-07 01-12-12

@gauravano gauravano merged commit 9a4923a into publiclab:master Aug 6, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger ⚠️ 1 Warning. Don't worry, everything is fixable.
Details

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Aug 6, 2019

@gauravano

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Merged 🎉 . Thanks for the great work @CleverFool77!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.