Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Subscribe tag and subscribe related tag mismatch working add post option when subscribed #6103

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@CleverFool77
Copy link
Member

commented Aug 4, 2019

Fixes #6097

Earlier -

In the one main card of Individual Tag page , we had a subscribe button but when I click on the button, it shows related tag, but not let us subscribe to that particular tag. We are only able to subscribe to related tags and not the main tag whose Individual page we are on.
Instead we have another button below called Subscribe to answer questions on this topic. And this button is the one which lets us subscribe to tag.

Screenshot from 2019-08-03 12-53-11

Now

Now I have added a subscribe button to subscribe to that particular tag on which page we are and For related tag, I have converted it to dropdown, so we have an option of subscribing to related tags too.

sub

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2019

Hi @jywarren @gauravano I just pushed the changes to this PR.
It would be great to have a review.
Thanks !!

@CleverFool77 CleverFool77 changed the title Subscribe tag and subscribe related tag mismatch working Fix Subscribe tag and subscribe related tag mismatch working Aug 4, 2019

@CleverFool77 CleverFool77 changed the title Fix Subscribe tag and subscribe related tag mismatch working Fix Subscribe tag and subscribe related tag mismatch working in Individual Tag page Aug 6, 2019

app/views/tag/show.html.erb Outdated Show resolved Hide resolved
@gauravano

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Also, can we soften the corners of Subscribe button with icon, just to make it a little better match with the adjacent button?

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

Also, can we soften the corners of Subscribe button with icon, just to make it a little better match with the adjacent button?

Hi @gauravano I didn't get it. What do you mean by softening the corners of Subscribe button ??

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Hi @gauravano You want me increase border radius of caret-down button ?

@gauravano

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Yeah, make the border radius equal for both the buttons same.

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

This looks almost ready! Great work!

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

I'll update this soon.
Thanks

@CleverFool77 CleverFool77 force-pushed the CleverFool77:sub branch from bb27cec to f13f8a9 Aug 16, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

Just updated !!
Thanks !!

Screenshot from 2019-08-16 11-27-27

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Ah hm, shouldn't border radius just be the Bootstrap defaults for both? Is custom CSS required?

And, perhaps we should leave it primary (blue) so we emphasize it.

Finally, as we'd soon be getting rid of the "subscribe to answer questions", what if the main part of the top Subscribe button just subscribed to the tag itself, but the dropdown portion showed related tags? Could that be a good compromise?

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

Hi Jeff.
That's exactly what I'm doing. Main part of subscribe button is subscribing to main tag only whereas dropdown is for related tags. So that if we want to Click and subscribe to related tags too then we can click on dropdown.

Regarding custom CSS. I'll see for impleting border radius using bootstrap and implement it.

Thanks

@CleverFool77 CleverFool77 force-pushed the CleverFool77:sub branch from f13f8a9 to 8568e02 Aug 17, 2019

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Aug 17, 2019

@CleverFool77 CleverFool77 reopened this Aug 17, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Aug 17, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

The test case failing in travis doesn't seem related to this PR.
I'll start the build again,
Thanks !!

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Aug 17, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

@CleverFool77 CleverFool77 changed the title Fix Subscribe tag and subscribe related tag mismatch working in Individual Tag page Fix Subscribe tag and subscribe related tag mismatch working add post option when subscribed Aug 27, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:sub branch from 8568e02 to d900404 Aug 27, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Hi @jywarren !!
I just updated the chnages you told me for this PR.
Here is the gif working of this -

  • First we have subscribe for particular tag and dropdown-btn for related tags.
  • If we click on this, we'll get subscribed. and Now we'll have post button in card.
  • We have option of subscribing and unsubscribing in ellipsis too.

sub

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

This looks super, and we should be good to merge it as soon as tests pass. I had removed the lower blue buttons on Ask a Question and subscribe to answer questions, in a previous commit, but I imagine that the auto-merge will take care of that here, no? Or are you re-adding those? If they are re-adding, would you mind removing them again? Thank you!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

We should be able to see if it correctly merges and omits those buttons once the screenshots are generated.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

I didn't fetched the latest commits. I guess that's where the problem is. I'll fix this !!

@CleverFool77 CleverFool77 force-pushed the CleverFool77:sub branch from d900404 to 5e9ee0f Aug 27, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

I rebased it and pushed it again. It's no longer there.

Screenshot from 2019-08-27 19-32-33

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Awesome! Ready to merge this ASAP, thank you! 🎉

Does Gautami perhaps need a little help with #6124 and #6114 ? Or is she not available at the moment?

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Hmm, a few tests seem to have failed? Odd...

image

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Strange, could it be related to #6128 ?

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Hi @jywarren
It's weird in travis. Why does it seems that all 458/458 tests in functional testing failed.
System test failure is not related.

ERROR["test__does_not_show_map_for_show_for_author", #<Minitest::Reporters::Suite:0x00005601d9b72c40 @name="TagControllerTest">, 87.469619599]
 test__does_not_show_map_for_show_for_author#TagControllerTest (87.47s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:612:in `block in <class:TagControllerTest>'
ERROR["test_does_not_show_note_for_show_for_author", #<Minitest::Reporters::Suite:0x00005601d846f5e8 @name="TagControllerTest">, 88.336055311]
 test_does_not_show_note_for_show_for_author#TagControllerTest (88.34s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:597:in `block in <class:TagControllerTest>'
ERROR["test_does_not_show_things_tagged_with_parent_tag", #<Minitest::Reporters::Suite:0x00005601d80e1598 @name="TagControllerTest">, 88.42045072500002]
 test_does_not_show_things_tagged_with_parent_tag#TagControllerTest (88.42s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:499:in `block in <class:TagControllerTest>'
ERROR["test_does_not_show_wiki_for_show_for_author", #<Minitest::Reporters::Suite:0x00005601d7d4a358 @name="TagControllerTest">, 88.44965742300008]
 test_does_not_show_wiki_for_show_for_author#TagControllerTest (88.45s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:587:in `block in <class:TagControllerTest>'
ERROR["test_should_have_a_active_asked_and_an_inactive_answered_tab_for_question", #<Minitest::Reporters::Suite:0x00005601dd5ff778 @name="TagControllerTest">, 89.43386358200007]
 test_should_have_a_active_asked_and_an_inactive_answered_tab_for_question#TagControllerTest (89.43s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:563:in `block in <class:TagControllerTest>'
ERROR["test_should_have_active_question_tab_for_question_for_show_for_author", #<Minitest::Reporters::Suite:0x00005601dd4c9318 @name="TagControllerTest">, 89.47837676799998]
 test_should_have_active_question_tab_for_question_for_show_for_author#TagControllerTest (89.48s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:553:in `block in <class:TagControllerTest>'
ERROR["test_should_list_answered_questions", #<Minitest::Reporters::Suite:0x00005601dd4013e0 @name="TagControllerTest">, 89.52152587700004]
 test_should_list_answered_questions#TagControllerTest (89.52s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:573:in `block in <class:TagControllerTest>'
ERROR["test_should_list_only_notes_in_notes_view", #<Minitest::Reporters::Suite:0x00005601dd2024e0 @name="TagControllerTest">, 89.57701728900008]
 test_should_list_only_notes_in_notes_view#TagControllerTest (89.58s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:436:in `block in <class:TagControllerTest>'
ERROR["test_should_list_only_question_in_question_view", #<Minitest::Reporters::Suite:0x00005601dd13cab0 @name="TagControllerTest">, 89.64301657700003]
 test_should_list_only_question_in_question_view#TagControllerTest (89.64s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:425:in `block in <class:TagControllerTest>'
ERROR["test_should_show_a_featured_wiki_page_at_top,_if_it_exists", #<Minitest::Reporters::Suite:0x00005601dd09b548 @name="TagControllerTest">, 89.71173760600004]
 test_should_show_a_featured_wiki_page_at_top,_if_it_exists#TagControllerTest (89.71s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:297:in `block in <class:TagControllerTest>'
ERROR["test_should_take_node_type_as_note_if_tag_is_not_a_question_tag", #<Minitest::Reporters::Suite:0x00005601dcf907e8 @name="TagControllerTest">, 89.76877041700004]
 test_should_take_node_type_as_note_if_tag_is_not_a_question_tag#TagControllerTest (89.77s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:417:in `block in <class:TagControllerTest>'
ERROR["test_should_take_node_type_as_note_if_tag_is_not_a_question_tag_for_show_for_author", #<Minitest::Reporters::Suite:0x00005601dcf158b8 @name="TagControllerTest">, 89.81168852200005]
 test_should_take_node_type_as_note_if_tag_is_not_a_question_tag_for_show_for_author#TagControllerTest (89.81s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:581:in `block in <class:TagControllerTest>'
ERROR["test_should_take_node_type_as_question_if_tag_is_a_question_tag", #<Minitest::Reporters::Suite:0x00005601dce5aea0 @name="TagControllerTest">, 89.87547268900005]
 test_should_take_node_type_as_question_if_tag_is_a_question_tag#TagControllerTest (89.88s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:409:in `block in <class:TagControllerTest>'
ERROR["test_show_note_with_author_and_tagname_with_wildcard", #<Minitest::Reporters::Suite:0x00005601dcce2eb0 @name="TagControllerTest">, 89.89979969800004]
 test_show_note_with_author_and_tagname_with_wildcard#TagControllerTest (89.90s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:318:in `block in <class:TagControllerTest>'
ERROR["test_show_note_with_author_and_tagname_without_wildcard", #<Minitest::Reporters::Suite:0x00005601dcd7ada0 @name="TagControllerTest">, 89.94221328399999]
 test_show_note_with_author_and_tagname_without_wildcard#TagControllerTest (89.94s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:303:in `block in <class:TagControllerTest>'
ERROR["test_show_page_for_non-existent_tag", #<Minitest::Reporters::Suite:0x00005601dcd21700 @name="TagControllerTest">, 89.97440850700002]
 test_show_page_for_non-existent_tag#TagControllerTest (89.97s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:185:in `block in <class:TagControllerTest>'
ERROR["test_shows_things_tagged_with_child_tag", #<Minitest::Reporters::Suite:0x00005601dcae3fb0 @name="TagControllerTest">, 90.14698430700003]
 test_shows_things_tagged_with_child_tag#TagControllerTest (90.15s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:466:in `block in <class:TagControllerTest>'
ERROR["test_tag_contributors", #<Minitest::Reporters::Suite:0x00005601da856e20 @name="TagControllerTest">, 90.73769412299998]
 test_tag_contributors#TagControllerTest (90.74s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:360:in `block in <class:TagControllerTest>'
ERROR["test_tag_show", #<Minitest::Reporters::Suite:0x00005601d9c6f170 @name="TagControllerTest">, 91.09368681900003]
 test_tag_show#TagControllerTest (91.09s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:167:in `block in <class:TagControllerTest>'
ERROR["test_tag_show,_sort_by_likes_DESC", #<Minitest::Reporters::Suite:0x00005601d9b9ad58 @name="TagControllerTest">, 91.14851122900006]
 test_tag_show,_sort_by_likes_DESC#TagControllerTest (91.15s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:197:in `block in <class:TagControllerTest>'
ERROR["test_tag_show,_sort_by_views_DESC", #<Minitest::Reporters::Suite:0x00005601d94ef0f8 @name="TagControllerTest">, 91.21892732399999]
 test_tag_show,_sort_by_views_DESC#TagControllerTest (91.22s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:190:in `block in <class:TagControllerTest>'
ERROR["test_tag_show_range", #<Minitest::Reporters::Suite:0x00005601d9ce5a00 @name="TagControllerTest">, 91.344425635]
 test_tag_show_range#TagControllerTest (91.34s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:204:in `block in <class:TagControllerTest>'
ERROR["test_tag_show_wiki_pages_with_author", #<Minitest::Reporters::Suite:0x00005601d9b7d190 @name="TagControllerTest">, 91.39872121000008]
 test_tag_show_wiki_pages_with_author#TagControllerTest (91.40s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:276:in `block in <class:TagControllerTest>'
ERROR["test_wildcard_does_not_show_map_for_show_for_author", #<Minitest::Reporters::Suite:0x00005601d998ae28 @name="TagControllerTest">, 91.533820042]
 test_wildcard_does_not_show_map_for_show_for_author#TagControllerTest (91.53s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:607:in `block in <class:TagControllerTest>'
ERROR["test_wildcard_does_not_show_note_for_show_for_author", #<Minitest::Reporters::Suite:0x00005601d9d2ac68 @name="TagControllerTest">, 91.55899326400004]
 test_wildcard_does_not_show_note_for_show_for_author#TagControllerTest (91.56s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:602:in `block in <class:TagControllerTest>'
ERROR["test_wildcard_does_not_show_wiki", #<Minitest::Reporters::Suite:0x00005601d9461528 @name="TagControllerTest">, 91.582884702]
 test_wildcard_does_not_show_wiki#TagControllerTest (91.58s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:290:in `block in <class:TagControllerTest>'
ERROR["test_wildcard_does_not_show_wiki_for_show_for_author", #<Minitest::Reporters::Suite:0x00005601d9c18280 @name="TagControllerTest">, 91.60591417900002]
 test_wildcard_does_not_show_wiki_for_show_for_author#TagControllerTest (91.61s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:592:in `block in <class:TagControllerTest>'
ERROR["test_wildcard_tag_should_have_a_active_asked_and_an_inactive_answered_tab_for_question", #<Minitest::Reporters::Suite:0x00005601d9dbe0f8 @name="TagControllerTest">, 91.637571159]
 test_wildcard_tag_should_have_a_active_asked_and_an_inactive_answered_tab_for_question#TagControllerTest (91.64s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:253:in `block in <class:TagControllerTest>'
ERROR["test_wildcard_tag_should_list_answered_questions", #<Minitest::Reporters::Suite:0x00005601d8dffbf8 @name="TagControllerTest">, 91.66877650800006]
 test_wildcard_tag_should_list_answered_questions#TagControllerTest (91.67s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:247:in `block in <class:TagControllerTest>'
ERROR["test_wildcard_tag_show", #<Minitest::Reporters::Suite:0x00005601d8520898 @name="TagControllerTest">, 91.69977794099998]
 test_wildcard_tag_show#TagControllerTest (91.70s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:228:in `block in <class:TagControllerTest>'
ERROR["test_wildcard_tag_show_wiki_pages", #<Minitest::Reporters::Suite:0x00005601d9712dd0 @name="TagControllerTest">, 91.72933224400003]
 test_wildcard_tag_show_wiki_pages#TagControllerTest (91.73s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:169:in `block (2 levels) in show'
            app/controllers/tag_controller.rb:168:in `show'
            test/functional/tag_controller_test.rb:236:in `block in <class:TagControllerTest>'
ERROR["test_wildcard_tag_show_wiki_pages_with_author", #<Minitest::Reporters::Suite:0x00005601d85937f8 @name="TagControllerTest">, 91.75187638300008]
 test_wildcard_tag_show_wiki_pages_with_author#TagControllerTest (91.75s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `following' for nil:NilClass
            app/views/tag/show.html.erb:21:in `_app_views_tag_show_html_erb__1720929235769753563_47282973004760'
            app/controllers/tag_controller.rb:230:in `block (2 levels) in show_for_author'
            app/controllers/tag_controller.rb:229:in `show_for_author'
            test/functional/tag_controller_test.rb:261:in `block in <class:TagControllerTest>'

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Aug 27, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Checking it once again and restarting the travis.

@CleverFool77 CleverFool77 reopened this Aug 27, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Aug 27, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Hi @jywarren @gauravano Is it the problem of travis or this PR ? As almost all the functions present in functional testing are failing.
Thanks !!!

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

I guess I found the problem.
Thanks !!!

@CleverFool77 CleverFool77 force-pushed the CleverFool77:sub branch from 5e9ee0f to d27c5f4 Sep 3, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

If not logged in

Screenshot from 2019-09-03 15-56-00
Screenshot from 2019-09-03 15-56-10

If logged in but not subscribed

caret down

Screenshot from 2019-09-03 15-57-19

main subscribe

subg

If logged in and subscribed

Screenshot from 2019-09-03 16-28-52

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

This system test seems to be failing and is unrelated to this.

ERROR["test_viewing_the_settings_page", #<Minitest::Reporters::Suite:0x00007f504dfba000 @name="SettingsTest">, 111.47383669699997]
 test_viewing_the_settings_page#SettingsTest (111.47s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `id' for nil:NilClass
            app/views/users/settings.html.erb:10:in `_app_views_users_settings_html_erb__3740544244043538035_69991441649640'
@jywarren

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Re #6179 ! I restarted it, fingers 🤞

@plotsbot

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2019

1 Warning
⚠️ There was an error with Danger bot’s Junit parsing: No JUnit file was found at output.xml
3 Messages
📖 @CleverFool77 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.
📖 #
Screenshots 📸 (click to expand)

6103-test_viewing_question_post.png

6103-test_signup_modal.png

6103-test_wiki.png

6103-test_tag_page.png

6103-test_searching_an_item_from_the_homepage.png

6103-test_blog_page_with_location_modal.png

6103-test_login.png

6103-test_wiki_page_with_inline_grids.png

6103-test_questions.png

6103-test_methods.png

6103-test_tag_by_author_page.png

6103-test_viewing_the_dropdown_menu.png

6103-test_simple-data-grapher_powertag.png

6103-test_viewing_the_settings_page.png

6103-test_login_modal.png

6103-test_comments.png

6103-test_stats.png

6103-test_tags.png

6103-test_wiki_revisions.png

6103-test_people.png

6103-test_front.png

6103-test_signup.png

6103-test_questions_shadow.png

6103-test_blog.png

6103-test_question_page.png

6103-test_front_page_with_navbar_search_autocomplete.png

6103-test_viewing_the_dashboard.png

Learn about automated screenshots

Generated by 🚫 Danger

@jywarren jywarren merged commit b6d5089 into publiclab:master Sep 4, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger ⚠️ 1 Warning. Don't worry, everything is fixable.
Details

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Sep 4, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

Hooray!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.