Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add popular tags in first column of profile section #6120

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@CleverFool77
Copy link
Member

commented Aug 9, 2019

Fixes #5891

Screenshot from 2019-08-09 18-50-07

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Hi @jywarren @gautamig54 In the design we have two rows of tags below the topic cards, In this one of the tags section is of preferred tags right ? which is usually added by user to its profile through this ?

Screenshot from 2019-08-09 18-33-43

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile-fix branch from a510053 to bf5110a Aug 9, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Recent update. Just pushed these changes -

Screenshot from 2019-08-09 18-50-07

@gautamig54

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

Hi @jywarren @gautamig54 In the design we have two rows of tags below the topic cards, In this one of the tags section is of preferred tags right ? which is usually added by user to its profile through this ?

Screenshot from 2019-08-09 18-33-43

Yes!

@@ -7,8 +7,24 @@
<%= render :partial => "map/userLeaflet" , locals: { haslocation: false, user: @profile_user } %>
<% end %>

<hr />
<br />
<br>

This comment has been minimized.

Copy link
@newbazz

newbazz Aug 9, 2019

Contributor

please keep up with the coding style, br should have a closing tag as it earlier had.

</span>
</div>

<br>

This comment has been minimized.

Copy link
@newbazz

newbazz Aug 9, 2019

Contributor

closing tag here as well.

This comment has been minimized.

Copy link
@CleverFool77

CleverFool77 Aug 10, 2019

Author Member

cool. I'll fix it.

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile-fix branch from bf5110a to 8f22c47 Aug 10, 2019

@gautamig54

This comment has been minimized.

Copy link
Contributor

commented Aug 11, 2019

Hi @CleverFool77 Just wanted to ask that these popular tags are specific to each user or in general popular tags of the website?

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Ah, @gautamig54 has a good point, this is a bit ambiguous. How is it described in the mockup? Can we clarify this via design or labeling?

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

Hi @gautamig54 @jywarren This popular tags are specific to each user !!!!

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

Hi @gautamig54 @jywarren This PR is for popular tag for specific user, I'll soon add another PR which would be for specific tags preferred by user and has been added by user in its profile.

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 15, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:profile-fix branch from 8f22c47 to c53bd25 Aug 16, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

Just updated !!

Screenshot from 2019-08-16 11-30-12

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

I'm not sure why travis is failing. Everything seemed to pass locally but not here !!

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Hm, can you click through into the tests and read the logs to see what the error is, and paste it back in here? Thanks!

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Aug 17, 2019

@CleverFool77 CleverFool77 reopened this Aug 17, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Aug 17, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

Hi @jywarren The error tests doesn't seem to be related to this PR.
It's something related to blog page modal !!

ERROR["test_blog_page_with_location_modal", #<Minitest::Reporters::Suite:0x00007f380ef874e0 @name="ScreenshotsTest">, 156.71562014200003]
 test_blog_page_with_location_modal#ScreenshotsTest (156.72s)
Capybara::ElementNotFound:         Capybara::ElementNotFound: Unable to find css "a.blurred-location-input"
            test/system/screenshots_test.rb:100:in `block in <class:ScreenshotsTest>

Thanks !!
I have closed and reopened this PR again to start the build. Let's see whats the result !!

@publiclab publiclab deleted a comment from jywarren Aug 17, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

Now all the checks seem to have passed after restarting the build.
Thanks !!

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

This PR seems ready !!! @jywarren
Thanks !!

@jywarren jywarren merged commit 1414c40 into publiclab:master Aug 19, 2019

3 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Congrats.

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Aug 19, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Great!!!! Super work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.