Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print,barnstar,delete feature and info of node to ellipsis and add test #6217

Open
wants to merge 1 commit into
base: master
from

Conversation

@CleverFool77
Copy link
Member

commented Aug 28, 2019

Fixes #6097

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

Earlier we had popover for all the toggle icons which is okk, but it limits down with lots of stuff. As We might have sub-drop-down for barnstars and various other feature. So I'm converting all the data-content in popovers to dropdowns.
I wanted to ask that do we have buttons for Spam, Delete, Raw` to be added in new dropdown ?
cc: @jywarren

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:dot branch from eedd51a to c2e1a9d Aug 30, 2019

@CleverFool77 CleverFool77 changed the title [WIP] Add print,barnstar,delete feature and info of node to `...` Add print,barnstar,delete feature and info of node to `...` Aug 30, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:dot branch from c2e1a9d to 22c03ff Aug 30, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Hi @jywarren
These are the screenshots -

Sidebar in Notes

Screenshot from 2019-08-30 17-19-47

Sidebar in notes with expanded submenu for users who liked

Screenshot from 2019-08-30 17-19-54

Sidebar in notes with expanded submenu for barnstar award

Screenshot from 2019-08-30 17-20-00

Sidebar in Wikis

Screenshot from 2019-08-30 17-19-11

Sidebar in question

Screenshot from 2019-08-30 17-19-29

@CleverFool77 CleverFool77 reopened this Aug 30, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

HI @jywarren I was going for system test, but I had doubt regarding the url. To have screenshot of the sidebar toggle icon dropdowns. We need a url for specific wiki, question or a note to take the screenshot for the dropdown. How should I go about testing it? Is it possible to get a url of the same from test database.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

restarting the build.

@CleverFool77 CleverFool77 reopened this Aug 30, 2019

@CleverFool77 CleverFool77 added this to In progress PRs in UI improvements - Summer Of Code 2019 via automation Aug 31, 2019

@CleverFool77 CleverFool77 requested a review from jywarren Aug 31, 2019

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Yes, you can do:

visit node(:about).path

in a system test! 👍

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:dot branch from 951033d to 3a3521d Sep 5, 2019

@@ -0,0 +1,15 @@
require "application_system_test_case"

class SidebarTest < ApplicationSystemTestCase

This comment has been minimized.

Copy link
@CleverFool77

CleverFool77 Sep 5, 2019

Author Member

Hi @jywarren I tried adding sidebar system test. Is it something like this ?

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

That looks right! Not sure why other tests are failing, could it be unrelated? I didn't have a moment to look in but I did restart them.

The only thing you may need is to add an assert_select to check that the dropdown is open and visible before taking the screenshot. That also inserts a short delay to let it appear properly. I believe this is demonstrated in some of the other system tests. Want to give it a try?

Hopefully the test re-run generates screenshots and we get to see!

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

HI @jywarren I'll add this part of assert_select
Thanks !!

@CleverFool77 CleverFool77 changed the title Add print,barnstar,delete feature and info of node to `...` Add print,barnstar,delete feature and info of node to ellipsis Sep 7, 2019

@CleverFool77 CleverFool77 force-pushed the CleverFool77:dot branch from 3a3521d to 2b42895 Sep 7, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

Hi @jywarren This PR has been updated.

@CleverFool77 CleverFool77 force-pushed the CleverFool77:dot branch from 2b42895 to c7b0c36 Sep 7, 2019

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Sep 8, 2019

@CleverFool77 CleverFool77 reopened this Sep 8, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Sep 8, 2019

@CleverFool77 CleverFool77 changed the title Add print,barnstar,delete feature and info of node to ellipsis Add print,barnstar,delete feature and info of node to ellipsis and add test Sep 8, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2019

Restarting the build.

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Failure of unrelated test.

ERROR["test_tag_blog", #<Minitest::Reporters::Suite:0x000055e7fee24730 @name="TagControllerTest">, 70.79219860300003]
 test_tag_blog#TagControllerTest (70.79s)
ActionView::Template::Error:         ActionView::Template::Error: undefined method `id' for nil:NilClass
            app/views/like/_like.html.erb:37:in `_app_views_like__like_html_erb___963048762514206274_47227359759100'
            app/views/tag/blog.html.erb:65:in `block in _app_views_tag_blog_html_erb___2596738057167986594_47227451466760'
            app/views/tag/blog.html.erb:46:in `each_with_index'
            app/views/tag/blog.html.erb:46:in `_app_views_tag_blog_html_erb___2596738057167986594_47227451466760'
            test/functional/tag_controller_test.rb:340:in `block in <class:TagControllerTest>'```

restarting the travis.

UI improvements - Summer Of Code 2019 automation moved this from In progress PRs to Done Sep 13, 2019

@CleverFool77 CleverFool77 reopened this Sep 13, 2019

UI improvements - Summer Of Code 2019 automation moved this from Done to In progress PRs Sep 13, 2019

@CleverFool77

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

I'll look into these errors.

@jywarren

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Try rebasing this maybe? Icarito merged a fix for test timing that may help even after you solve the test issues!

@CleverFool77 CleverFool77 force-pushed the CleverFool77:dot branch from c7b0c36 to b2c4a0d Sep 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.