Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update revisions.html.erb to update translation helpers #6672

Merged
merged 1 commit into from Nov 19, 2019

Conversation

stefanosu
Copy link
Contributor

@stefanosu stefanosu commented Nov 4, 2019

Fixes #6740
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [✔️ ] PR is descriptively titled 📑 and links the original issue above 🔗
  • [✔️ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [✔️ ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [✔️ ] screenshots/GIFs are attached 📎 in case of UI updation
  • [✔️ ] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@jywarren
Copy link
Member

jywarren commented Nov 4, 2019

Oh, goodness... @stefanosu you've opened something like 50 pull requests!

wow a lot of hard work
uh, i'm sorry @stefanosu we aren't able to respond to PRs that quickly

we appreciate your help
but your PRs don't reference the issue they are intended to fix, so we can't trace if they successfully complete the correct issue

I think they are related to @nstjean's translation helper changes -- maybe @stefanosu went down the whole list?

What shall we do? I want to be sure these changes don't overwrite another contributor's work
if someone else has claimed the FTO

@stefanosu would you be willing to close all your PRs and consider submitting them as one PR?

@jywarren
Copy link
Member

jywarren commented Nov 4, 2019

Hi, after some discussion we'd like to ask you to focus on just one instance of this -- and can you link back to the issue it came from? @nstjean maybe you can help with the link. Let's get this PR ready to merge and we can close the others, as we are hoping to use them to help welcome in other contributors. I hope you understand, and know that we appreciate your contribution! Thank you!

@nstjean
Copy link
Contributor

nstjean commented Nov 4, 2019

Here is the link!: #6579

@stefanosu
Copy link
Contributor Author

Hi @jywarren sorry for this mishap on that I thought I was referencing the issue correctly on each individual pr. Yea I did go down the whole list sorry for that. Yes, I could be able to do that. Sure of course no problem I understand.

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good..@stefanosu could you please add a screenshot? Thanks

@stefanosu
Copy link
Contributor Author

Looks good..@stefanosu could you please add a screenshot? Thanks

thanks, I'll add the screenshot but I'm having trouble running the server. I'm getting this error:

`connect': Access denied for user 'stefanosugbit'@'localhost' (using password: NO) (Mysql2::Error::ConnectionError)

@nstjean
Copy link
Contributor

nstjean commented Nov 11, 2019

@stefanosu Can you please post your problem in this thread about installing plots2? #3840 It looks like it's not connecting to the mysql database on startup.

@cesswairimu
Copy link
Collaborator

cesswairimu commented Nov 11, 2019

Hey @stefanosu, You can try using sqlite3 for development if mysql is giving you a headache.

You can replace your config.database.yml with

development:
  adapter: sqlite3
  database: development.sqlite

production:
  adapter: sqlite3
  database: production.sqlite

test:
  adapter: sqlite3
  database: test.sqlite


Then run rake db:setup

@stefanosu
Copy link
Contributor Author

Hey @stefanosu, You can try using sqlite3 for development if mysql is giving you a headache.

You can replace your config.database.yml with

development:
  adapter: sqlite3
  database: development.sqlite

production:
  adapter: sqlite3
  database: production.sqlite

test:
  adapter: sqlite3
  database: test.sqlite

Then run rake db:setup

@cesswairimu Thanks that worked got the server up and running!

@cesswairimu
Copy link
Collaborator

cesswairimu commented Nov 12, 2019

awesome 🎉

@jywarren jywarren changed the title Update revisions.html.erb Update revisions.html.erb to update translation helpers Nov 19, 2019
@jywarren
Copy link
Member

This looks super and I'm merging it now! Great work!

@jywarren jywarren merged commit 71e9628 into publiclab:master Nov 19, 2019
@welcome
Copy link

welcome bot commented Nov 19, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this pull request Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update app/views/wiki/revisions.html.erb translations
4 participants