Spam2: system for flagging nodes and comments to moderators and User moderation #8107

keshavsethi · 2020-07-02T14:58:44Z

I have added the feature of Flag Nodes in spam2 in which any user can mark node as a flag. It will not affect the status of the node.

Flag will just increase the flag count by 1. If flag is 0 then it means that the node is not flagged and it is ok. All the flagged nodes will be listed on the flags page of spam2. Right now I have done it for nodes and working for flag comments as well.(refer #8107 (comment))

If flag count is above 10 then flag icon also becomes red.

Here are a few screenshots

Here flag count in shown in the status column and red icon indicates that the flag count is more than 10. Spamming that node will also unflag it as it is moderated.

@jywarren @cesswairimu @VladimirMikulic @ananyaarun @emilyashley @pydevsg @ebarry @Uzay-G Please review
Thanks!!

codecov · 2020-07-02T15:01:48Z

Codecov Report

Merging #8107 into main will decrease coverage by 0.25%.
The diff coverage is 62.13%.

@@            Coverage Diff             @@
##             main    #8107      +/-   ##
==========================================
- Coverage   82.10%   81.84%   -0.26%     
==========================================
  Files         100      100              
  Lines        5751     5845      +94     
==========================================
+ Hits         4722     4784      +62     
- Misses       1029     1061      +32

Impacted Files	Coverage Δ
app/controllers/spam2_controller.rb	`76.78% <53.57%> (-23.22%)`	⬇️
app/controllers/admin_controller.rb	`80.24% <100.00%> (+0.24%)`	⬆️
app/models/comment.rb	`77.51% <100.00%> (+0.62%)`	⬆️
app/models/node.rb	`91.18% <100.00%> (+0.12%)`	⬆️
app/api/srch/search.rb	`70.06% <0.00%> (+3.82%)`	⬆️
app/services/execute_search.rb	`94.44% <0.00%> (+5.55%)`	⬆️

ebarry · 2020-07-02T15:10:42Z

This is a great idea!
Who sees the red flag, and where?

Only moderators looking at the /spam dashboard?
Regular users browsing content?

VladimirMikulic

Since everything is centred, you could as well centre this section with control buttons:
https://i.imgur.com/YC7Xn5y.png

keshavsethi · 2020-07-02T15:30:55Z

This is a great idea!
Who sees the red flag, and where?

Only moderators looking at the /spam dashboard?

Regular users browsing content?

@ebarry Regular users can just flag a node. List of flag nodes and that red flag icon is only visible to moderators at /spam2/flags.

Thanks!!

keshavsethi · 2020-07-02T15:35:47Z

Since everything is centred, you could as well centre this section with control buttons:
https://i.imgur.com/YC7Xn5y.png

@VladimirMikulic Sure, I will do that. Thanks!!

pydevsg

@keshav234156 can you please share screenshot of the change, thanks

pydevsg · 2020-07-04T19:14:28Z

@keshavsethi , the UI is pretty good, have you made this response as well or it's currently made for the Desktop version?

keshavsethi · 2020-07-05T21:36:47Z

@jywarren @cesswairimu @VladimirMikulic @ananyaarun @emilyashley @pydevsg @ebarry @Uzay-G
I have also done flag comments in this PR. Here, any user can mark comments as a flag(it will not affect the status of a comment). Moderators can see those flag comments in /spam2/comments that have all the features like publish, spam, etc. moderator can identify flag comments through the icon with node title and active unflag button.
It is sorted as per flag count. I am currently working on its bulk moderation and tests

@jywarren @cesswairimu @VladimirMikulic @ananyaarun @emilyashley @pydevsg @ebarry @Uzay-G
Please review
Thanks!!

keshavsethi · 2020-07-05T21:38:45Z

@keshavsethi , the UI is pretty good, have you made this response as well or it's currently made for the Desktop version?

Yes, all the pages in /spam2 are responsive

keshavsethi · 2020-07-05T21:43:31Z

@keshav234156 can you please share screenshot of the change, thanks

@VladimirMikulic @pydevsg I have aligned bulk nav

Thanks!!

cesswairimu · 2020-07-06T16:45:03Z

app/controllers/spam2_controller.rb

+    if @node.flag == 0
+      flash[:notice] = 'Node already unflagged.'
+    else
+      @node.unflag_node


we might wonna check if the person who flagged it or if (moderator or admin) can only unflag it, this may complicate the feature..but let me know what you think

I have added an if statement to check only moderators and admins can unflag item
Thanks

cesswairimu · 2020-07-06T16:46:01Z

app/models/comment.rb

+    self
+  end
+
+  def unflag_comment


maybe for this we could reduce the flags...but if its a moderator/admin we set it to 0...what do you think?

But for this, we have to show flag count to users as well. Right now unflag means only moderators can unflag (i.e reduce flag count to 0). Other users can just flag nodes i.e increase its flag count by 1

gotcha, cool, sounds good...thanks for the clarification

pydevsg · 2020-07-06T19:03:59Z

Ah great work man , this UI is really clean and crisp. Keep up the good work @keshavsethi 🎉

jywarren · 2020-07-07T19:24:39Z

Looking really nice! One suggestion is to use lots of Bootstrap tooltips:

https://getbootstrap.com/docs/4.4/components/tooltips/

to add short explanatory texts over things like the flag icon, without needing a lot of space! What do you think?

jywarren

Hi @keshavsethi I would also like to request that you add some tests -- to demonstrate how it is supposed to work, and to ensure it's protected against future changes. I know this is a lot, but it is really a critical part of a big feature like this so I appreciate it!

unit tests for changes to the models
functional tests for controller actions
system tests for javascript actions (pressing buttons, complex integrated sequences like several actions chained together)

Does this make sense? Thank you so much!

keshavsethi · 2020-07-07T20:46:15Z

Looking really nice! One suggestion is to use lots of Bootstrap tooltips:

https://getbootstrap.com/docs/4.4/components/tooltips/

to add short explanatory texts over things like the flag icon, without needing a lot of space! What do you think?

@jywarren I have added a few in bulk moderation nav.

keshavsethi · 2020-07-20T05:30:22Z

@jywarren @cesswairimu @pydevsg @VladimirMikulic @ebarry, I have added the User moderation page here where the moderator can ban and unban users. I have also added filters for admin moderators and banned users. Can you Please review and merge this PR as I am stuck here. This PR is getting bigger and has so many changes. You can review it in gitpod as well(it might give an error in the dashboard but can just change URL to spam2 and test it). Thanks!!

In my future PRs, I am planning to add a search feature and Queue where the moderator can moderate only those nodes which have tags that they are following.
Please review 🙏
Thanks!! ❤️

keshavsethi · 2020-07-21T16:36:52Z

@jywarren @cesswairimu I have updated the UI a bit and completed user bulk moderation. Please review!!
This PR is getting Bigger, Please review and merge if it is fine. 🙏

Please review and merge if it is fine. Thanks!!

jywarren · 2020-07-21T16:37:15Z

Reviewing this now! Thanks @keshavsethi for your patience. I hope we can work more modularly and that GitPod helps us review faster, so you get un-stuck!

jywarren · 2020-07-21T16:37:44Z

It's booting up in GitPod! 🕐 😄

keshavsethi · 2020-07-21T16:38:58Z

@jywarren I have made some changes in gitpod #8162 It is working fine there.

jywarren · 2020-07-21T17:31:03Z

OK!

Nice!

jywarren · 2020-07-21T17:33:07Z

Hmm. i'm still getting hit by Mysql2::Error: Expression #3 of SELECT list is not in GROUP BY clause so i'm going to try to resolve that first! But the page looks great so i am pretty confident it'll be good to merge today!

jywarren · 2020-07-21T18:22:30Z

test/system/dashboard_test.rb

@@ -22,5 +22,16 @@ class DashboardTest < ApplicationSystemTestCase
    take_screenshot

  end
-
+
+  test "User can flag a node from dashboard" do


Awesome. Thanks!

jywarren · 2020-07-21T18:42:52Z

I'm content with how this looks so far! Thank you! The tests were super helpful and I loved being able to try it out on GitPod. Thanks and congratulations, @keshavsethi !!!

keshavsethi · 2020-07-21T19:04:24Z

Thank you so much @jywarren 🎉 🎉 ❤️

…moderation (publiclab#8107) * spam2 flag nodes * nav align * flag comment moderation * flag comment order * spam2 flag comments * spam2 flag and filters update * codeclimate issue * codeclimate issue2 * reduce filters * spam2 code climate * test issues spam2 * spam2 flag filters * spam2 flag tests * flag spam2 test issue * flag count and ui update * spam2 typo in tests * spam2 syatem test update * user moderation and search feature * indentation * user moderation * indentation * UI update of spam2 * spam2 ui update * bulk user moderation * bulk user moderation spam2 * refactoring spam2 * spam2 refactoring

keshavsethi requested a review from a team as a code owner July 2, 2020 14:58

keshavsethi requested review from nstjean, VladimirMikulic, cesswairimu, jywarren and pydevsg July 2, 2020 15:01

keshavsethi changed the title ~~spam2: Flag Nodes~~ Spam2: Flag Nodes Jul 2, 2020

VladimirMikulic requested changes Jul 2, 2020

View reviewed changes

keshavsethi requested a review from SidharthBansal July 2, 2020 16:19

pydevsg reviewed Jul 4, 2020

View reviewed changes

keshavsethi requested a review from a team as a code owner July 5, 2020 18:30

keshavsethi closed this Jul 5, 2020

keshavsethi reopened this Jul 5, 2020

keshavsethi requested review from pydevsg and VladimirMikulic July 5, 2020 21:45

keshavsethi changed the title ~~Spam2: Flag Nodes~~ Spam2: Flag Nodes and Comments Jul 5, 2020

keshavsethi mentioned this pull request Jul 6, 2020

Weekly Community Check-In #66 - Outreachy Mid-term feedback #8113

Closed

cesswairimu reviewed Jul 6, 2020

View reviewed changes

jywarren requested changes Jul 7, 2020

View reviewed changes

keshavsethi added 6 commits July 21, 2020 21:22

UI update of spam2

31f212b

spam2 ui update

2156613

bulk user moderation

420c486

bulk user moderation spam2

e6e8854

refactoring spam2

53db7d7

spam2 refactoring

91b98ca

jywarren reviewed Jul 21, 2020

View reviewed changes

jywarren approved these changes Jul 21, 2020

View reviewed changes

jywarren mentioned this pull request Jul 21, 2020

fixing GitPod mysql db, and try opening rails console in a gitpod terminal #8152

Merged

jywarren merged commit d5cc30c into publiclab:main Jul 21, 2020

keshavsethi mentioned this pull request Jul 28, 2020

GSoC'20: "Spam Management Dashboard" Project Planning #7885

Closed

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spam2: system for flagging nodes and comments to moderators and User moderation #8107

Spam2: system for flagging nodes and comments to moderators and User moderation #8107

keshavsethi commented Jul 2, 2020 •

edited by jywarren

codecov bot commented Jul 2, 2020 •

edited

ebarry commented Jul 2, 2020

VladimirMikulic left a comment

keshavsethi commented Jul 2, 2020 •

edited

keshavsethi commented Jul 2, 2020

pydevsg left a comment

pydevsg commented Jul 4, 2020

keshavsethi commented Jul 5, 2020 •

edited

keshavsethi commented Jul 5, 2020

keshavsethi commented Jul 5, 2020

cesswairimu Jul 6, 2020 •

edited

keshavsethi Jul 7, 2020

cesswairimu Jul 6, 2020

keshavsethi Jul 7, 2020

cesswairimu Jul 8, 2020

pydevsg commented Jul 6, 2020

jywarren commented Jul 7, 2020

jywarren left a comment

keshavsethi commented Jul 7, 2020

keshavsethi commented Jul 20, 2020 •

edited

keshavsethi commented Jul 21, 2020

jywarren commented Jul 21, 2020

jywarren commented Jul 21, 2020

keshavsethi commented Jul 21, 2020 •

edited

jywarren commented Jul 21, 2020

jywarren commented Jul 21, 2020

jywarren Jul 21, 2020

jywarren commented Jul 21, 2020

keshavsethi commented Jul 21, 2020

Spam2: system for flagging nodes and comments to moderators and User moderation #8107

Spam2: system for flagging nodes and comments to moderators and User moderation #8107

Conversation

keshavsethi commented Jul 2, 2020 • edited by jywarren

codecov bot commented Jul 2, 2020 • edited

Codecov Report

ebarry commented Jul 2, 2020

VladimirMikulic left a comment

Choose a reason for hiding this comment

keshavsethi commented Jul 2, 2020 • edited

keshavsethi commented Jul 2, 2020

pydevsg left a comment

Choose a reason for hiding this comment

pydevsg commented Jul 4, 2020

keshavsethi commented Jul 5, 2020 • edited

keshavsethi commented Jul 5, 2020

keshavsethi commented Jul 5, 2020

cesswairimu Jul 6, 2020 • edited

Choose a reason for hiding this comment

keshavsethi Jul 7, 2020

Choose a reason for hiding this comment

cesswairimu Jul 6, 2020

Choose a reason for hiding this comment

keshavsethi Jul 7, 2020

Choose a reason for hiding this comment

cesswairimu Jul 8, 2020

Choose a reason for hiding this comment

pydevsg commented Jul 6, 2020

jywarren commented Jul 7, 2020

jywarren left a comment

Choose a reason for hiding this comment

keshavsethi commented Jul 7, 2020

keshavsethi commented Jul 20, 2020 • edited

keshavsethi commented Jul 21, 2020

jywarren commented Jul 21, 2020

jywarren commented Jul 21, 2020

keshavsethi commented Jul 21, 2020 • edited

jywarren commented Jul 21, 2020

jywarren commented Jul 21, 2020

jywarren Jul 21, 2020

Choose a reason for hiding this comment

jywarren commented Jul 21, 2020

keshavsethi commented Jul 21, 2020

keshavsethi commented Jul 2, 2020 •

edited by jywarren

codecov bot commented Jul 2, 2020 •

edited

keshavsethi commented Jul 2, 2020 •

edited

keshavsethi commented Jul 5, 2020 •

edited

cesswairimu Jul 6, 2020 •

edited

keshavsethi commented Jul 20, 2020 •

edited

keshavsethi commented Jul 21, 2020 •

edited