Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused code from View.js #72

Closed
wants to merge 2 commits into from
Closed

Removed unused code from View.js #72

wants to merge 2 commits into from

Conversation

noah56
Copy link

@noah56 noah56 commented Jul 25, 2019

Fixes #68

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers or the user who published the issue for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help!

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@noah56
Copy link
Author

noah56 commented Jul 25, 2019

@IshaGupta18 , Is this correct?

@IshaGupta18
Copy link
Collaborator

Hey I am afraid not, you weren't supposed to remove the entire line of drawHTMLView(), jus the part I had mentioned! Could you please fix that?

@noah56 noah56 closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing unused code
2 participants