Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The graph div should be made responsive. #110

Open
sidntrivedi012 opened this issue Jul 21, 2019 · 8 comments

Comments

@sidntrivedi012
Copy link
Member

commented Jul 21, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@sidntrivedi012

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2019

We have a graph div of the source of the capture demo here -

<div id="graph"></div>

This div is styled in the capture.css file here -
#graph {
width: 1024px;
height: 200px;
margin: 10px 0px;
}

But, the graph is not yet responsive in different screen sizes. But, it can be made responsive using media queries. More on media queries here - https://css-tricks.com/snippets/css/media-queries-for-standard-devices/
Thanks 🎉 🎈 🔬 💯

@dimkov41

This comment has been minimized.

Copy link

commented Jul 22, 2019

Which screen sizes you want to cover? All from the published link?

@sidntrivedi012

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

@dimkov41 Hey, thanks for reaching out for this fto issue.

Yes, you can try for maybe start with implementing media queries for small screen sizes like 320px and 480 px ? Having done that, you can add queries for big screen sizes of 768px and 1024 px too.

If you face any issue, feel free to ping. Thanks. 🎉 🎈 🔬 💯

@dimkov41

This comment has been minimized.

Copy link

commented Jul 23, 2019

I can't start project. Sorry! It can't find some module: Error: Cannot find module 'uri-js'

@sidntrivedi012

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

Hey @dimkov41 , can you please share the whole error message? Also, we have to add the responsive nature to the graph div which is present in index.html file in the examples/capture directory.

@starkblaze01

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

Hi, @dimkov41, have you installed node modules?. Please run
npm i or npm install then restart the project.

@sidntrivedi012

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

@dimkov41 Are you still working on it? Any updates?

@dimkov41

This comment has been minimized.

Copy link

commented Aug 11, 2019

No. I don't work on it, because I can't start the project as I told before.

gyp ERR! build error
gyp ERR! stack Error: make failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/share/node-gyp/lib/build.js:258:23)
gyp ERR! stack at emitTwo (events.js:126:13)
gyp ERR! stack at ChildProcess.emit (events.js:214:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Linux 4.15.0-54-generic
gyp ERR! command "/usr/bin/node" "/usr/bin/node-gyp" "rebuild"
gyp ERR! cwd /home/dimkov/Documents/Developing/spectral-workbench.js/node_modules/contextify
gyp ERR! node -v v8.10.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm WARN grunt-contrib-watch@0.6.1 requires a peer of grunt@~0.4.0 but none was installed.
npm WARN grunt-contrib-connect@0.8.0 requires a peer of grunt@~0.4.0 but none was installed.
npm WARN grunt-contrib-jshint@0.10.0 requires a peer of grunt@~0.4.0 but none was installed.
npm WARN grunt-contrib-uglify@0.5.1 requires a peer of grunt@~0.4.0 but none was installed.
npm ERR! Linux 4.15.0-54-generic
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "update"
npm ERR! node v8.10.0
npm ERR! npm v3.5.2
npm ERR! code ELIFECYCLE
npm ERR! contextify@0.1.15 install: node-gyp rebuild
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the contextify@0.1.15 install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the contextify package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs contextify
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls contextify
npm ERR! There is likely additional logging output above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.