Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in the demo #113

Open
sidntrivedi012 opened this issue Jul 23, 2019 · 11 comments

Comments

@sidntrivedi012
Copy link
Member

commented Jul 23, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

@sidntrivedi012

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

We have our demo located in the example/capture directory. Unfortunately, Browser is mistakingly written as Bowser. It will be very helpful if you can correct it and thus, get started with knowing more about the project.
Screenshot 2019-07-24 at 2 58 46 AM

Thanks ! 🎉 🎈 💯 🔬

@Lionel-Stewart

This comment has been minimized.

Copy link

commented Jul 23, 2019

Hi, I am a first-timer, and would like to work on the issue or help.

@sidntrivedi012

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

Sure @Lionel-Stewart . Go ahead. 💯 👍

@Lionel-Stewart

This comment has been minimized.

Copy link

commented Jul 23, 2019

I fixed the type in html, but the href link https://itunes.apple.com/us/app/bowser/id560478358 also has bowser in it. Just checking, but do I fix the link as well, or just the html.

@Lionel-Stewart

This comment has been minimized.

Copy link

commented Jul 23, 2019

Alright I just submitted first pull request, hope that is satisfactory. Thanks for the experience and easy task for first try.

@sidntrivedi012

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

@jywarren , Shouldn't that be Browser? Actually, it didn't show up in my iTunes market thus, I suspected it to be a typo.

@sidntrivedi012

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

@Lionel-Stewart Awesome. Lets see what Jeff has to say about this and then we can review you PR. Thanks.

@honeykhatri

This comment has been minimized.

Copy link

commented Jul 24, 2019

Hi I am a first timer and I would like to fix this issue

@Sliver-bug

This comment has been minimized.

Copy link

commented Jul 24, 2019

Hi, i am a first timer and would like to fix this issue.

@sidntrivedi012

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

Hey @honeykhatri @Sliver-bug ,

@Lionel-Stewart has already sent a patch for this issue. But, its really great that you reached out to help us. We appreciate it a lot. There are a lot of first-timers-only issues waiting to be solved and taken up not only in this project but many other interesting projects of Public Lab. You can find them in our Community Toolbox - https://code.publiclab.org . Go ahead.

Thanks 🎉 🎈 🔬 🚀

@Sliver-bug

This comment has been minimized.

Copy link

commented Jul 24, 2019

Thanks, will be in touch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.