Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Securepoint Dynamic DNS - spdyn #235

Merged
merged 3 commits into from Nov 10, 2016

Conversation

@Naugrimm
Copy link
Contributor

commented May 31, 2016

No description provided.

@Naugrimm

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2016

  • DNS updated
@sleif

This comment has been minimized.

Copy link

commented Jul 7, 2016

I'm looking forward to this! I want to secure my owncloud server access.

@ghost

This comment has been minimized.

Copy link

commented Jul 8, 2016

Me too!

@mommmomm

This comment has been minimized.

Copy link

commented Jul 20, 2016

Tanks for adding spdns.de and all the other spdyn domains,, Naugrimm!

@PSL How long can such a simple merge possibly take?

@migasQ

This comment has been minimized.

Copy link

commented Aug 15, 2016

*push

@sleevi

This comment has been minimized.

Copy link
Member

commented Aug 16, 2016

Please see https://github.com/publicsuffix/list/wiki/Guidelines on how to properly format a Pull Request so that it can be validated and merged.

@Naugrimm Naugrimm force-pushed the Naugrimm:securepoint-spdyn branch from 9234f26 to c08abde Aug 17, 2016

@Naugrimm

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2016

@sleevi

  • modified pull request
@rsdev277

This comment has been minimized.

Copy link

commented Sep 18, 2016

I'm looking forward to this!

@logopk

This comment has been minimized.

Copy link

commented Oct 18, 2016

Need this too. Please!

@ohunecker

This comment has been minimized.

Copy link

commented Oct 26, 2016

Please merge!

@stefanLeo

This comment has been minimized.

Copy link

commented Oct 31, 2016

Looking forward to it as well! - Pls. merge 👍

@sleevi sleevi added r=sleevi and removed pending-validation labels Oct 31, 2016

@sleevi

This comment has been minimized.

Copy link
Member

commented Oct 31, 2016

Please do not comment on "Please merge" - GitHub has reactions for that reason.

As it stands, this cannot be merged because it needs to be rebased (see the status below). Once done we can merge.

@freaky-m0

This comment has been minimized.

Copy link

commented Nov 9, 2016

So it is still not possible to use Let's Encrypt with SPDYN/SPDNS Domains? I get an error if i try it with my Synology NAS. "Too many requests....." I don't understand this public suffix stuff ;)

@weppos

This comment has been minimized.

Copy link
Member

commented Nov 9, 2016

@Naugrimm the PR looks good however, before proceeding, I actually want to notify you that quite a few things changed since May and the correct way to avoid the Let's Encrypt limits is to request the limits to be adjusted using the official form as described in https://letsencrypt.org/docs/rate-limits/

Therefore, merging this PR, may not affect Let's Encrypt at all, but instead will have consequences on how clients will interpret your domains.

Are you aware of this? Given this change, do you still want to proceed?

@Naugrimm

This comment has been minimized.

Copy link
Contributor Author

commented Nov 10, 2016

@weppos I was not aware of the changes to the rate-limiting. Thank you. I will reach out to the letsencrypt people to see if there is a solution for dyndns-providers.

Nevertheless we think the domains our customers use should appear in the PSL, so someone who owns a.spdns.de can not set a cookie for .spdns.de that gets transmitted to all other users of this 2nd-level-domain.

So if I did not totally misunderstood the concept of the PSL, I kindly ask you to merge this PR.

@weppos
weppos approved these changes Nov 10, 2016

@weppos weppos merged commit efd14ba into publicsuffix:master Nov 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@weppos weppos self-assigned this Nov 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.