New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enginifying Publify? #516

Closed
benlovell opened this Issue Oct 16, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@benlovell

benlovell commented Oct 16, 2014

Hey, nice work. We're adopting publify for a fairly significant project and one thing I'm personally having difficulty with is our approach to upstreaming changes. The idea that you take a snapshot of publify at a particular point in time and make your modifications as you see fit.

Occasionally you'll need to make a modification that doesn't sit well with the 'theme' way of thinking and the tendency is to try and shoe-horn something in where it doesn't make sense.

I think if publify was self-contained within an engine it would be easier to install/maintain. Any thoughts?

@mvz

This comment has been minimized.

Show comment
Hide comment
@mvz

mvz Oct 16, 2014

Member

Making Publify an engine would be great. Publify as it is distributed today would then simply become a ready-to-run installation of that engine.

That said, we don't have any concrete plans to do this, but it's definitely on our (at least my) mind.

If you have any guidance to offer on how to get this done, that would be awesome.

Member

mvz commented Oct 16, 2014

Making Publify an engine would be great. Publify as it is distributed today would then simply become a ready-to-run installation of that engine.

That said, we don't have any concrete plans to do this, but it's definitely on our (at least my) mind.

If you have any guidance to offer on how to get this done, that would be awesome.

@j-a-m-l

This comment has been minimized.

Show comment
Hide comment
@j-a-m-l

j-a-m-l Feb 4, 2015

👍

I feel the same way and I think that it's the best approach for starting complex projects.

In my experience, creating an engine from a previous app, it's harder than it seems, so @mvz, I would start extracting some smaller pieces into new reusable projects, like the trackback system.

j-a-m-l commented Feb 4, 2015

👍

I feel the same way and I think that it's the best approach for starting complex projects.

In my experience, creating an engine from a previous app, it's harder than it seems, so @mvz, I would start extracting some smaller pieces into new reusable projects, like the trackback system.

This was referenced Jun 18, 2016

@mvz mvz added this to the 8.4.0 milestone Jun 24, 2016

@mvz

This comment has been minimized.

Show comment
Hide comment
@mvz

mvz Jun 24, 2016

Member

I'm actually going the other route: I'm mass-extracting all of Publify into an engine in the same repository as a first step.

Member

mvz commented Jun 24, 2016

I'm actually going the other route: I'm mass-extracting all of Publify into an engine in the same repository as a first step.

@mvz mvz changed the title from Enginifying publify? to Enginifying Publify? Jun 24, 2016

@mvz mvz referenced this issue Jun 28, 2016

Merged

Enginify Publify #718

2 of 4 tasks complete
@mvz

This comment has been minimized.

Show comment
Hide comment
@mvz

mvz Nov 13, 2016

Member

The extraction to several engines has been implemented in master. Next step is to actually have gems.

Member

mvz commented Nov 13, 2016

The extraction to several engines has been implemented in master. Next step is to actually have gems.

@mvz

This comment has been minimized.

Show comment
Hide comment
@mvz

mvz Nov 28, 2016

Member

We have gems!

Member

mvz commented Nov 28, 2016

We have gems!

@mvz mvz closed this Nov 28, 2016

@benlovell

This comment has been minimized.

Show comment
Hide comment
@benlovell

benlovell commented Nov 28, 2016

Nice 👍

@mvz mvz modified the milestones: 8.4.0, 9.0.0 Dec 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment