cleaning up published_at handling #53

Merged
merged 2 commits into from Nov 2, 2011

Conversation

Projects
None yet
3 participants
@mreinsch
Contributor

mreinsch commented Nov 2, 2011

The first commit introduces two named scopes on article to unify the published handling.
The second commit switches to use the article's published_at date instead of the created_at date to determine when comments should be closed.

ook added a commit that referenced this pull request Nov 2, 2011

Merge pull request #53 from mreinsch/master
cleaning up published_at  handling

@ook ook merged commit 901f8d6 into publify:master Nov 2, 2011

@ook

This comment has been minimized.

Show comment Hide comment
@ook

ook Nov 2, 2011

Owner

Oh god! Some semantic in that old ante-Rails2.1 craps :)

Thank you.

Owner

ook commented Nov 2, 2011

Oh god! Some semantic in that old ante-Rails2.1 craps :)

Thank you.

@mvz

This comment has been minimized.

Show comment Hide comment
@mvz

mvz Nov 8, 2011

Looks like we should have some duscssion about whether to use mocking and stubbing or factories to test our controllers...

mvz commented on daec85a Nov 8, 2011

Looks like we should have some duscssion about whether to use mocking and stubbing or factories to test our controllers...

This comment has been minimized.

Show comment Hide comment
@mreinsch

mreinsch Nov 8, 2011

Owner

well, you are using factories in other controller tests. I prefer factories (we rarely use stubbing/mocking), less work and less fragile. But in the end that's your call.

Owner

mreinsch replied Nov 8, 2011

well, you are using factories in other controller tests. I prefer factories (we rarely use stubbing/mocking), less work and less fragile. But in the end that's your call.

This comment has been minimized.

Show comment Hide comment
@mvz

mvz Nov 9, 2011

Ah no, by 'we', I meant the Typo developers. We've been using factories for a long time, but since that makes our tests really slow, I'd like to use stubbing and mocking more.

mvz replied Nov 9, 2011

Ah no, by 'we', I meant the Typo developers. We've been using factories for a long time, but since that makes our tests really slow, I'd like to use stubbing and mocking more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment