Enginify Publify #718
Merged
Enginify Publify #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
- Generate engine using
rails plugin new publify_core \
--dummy-path=spec/dummy --skip-test-unit --full
- Update gemspec and license
- Moves all models to the Engine - Moves a minimum set of supporting libraries, which includes the text filters. - Moves 'plain' theme, but not the bootstrap-2 theme. As a result, the default theme for a new Blog is 'plain'. - Unifies DNS mocks across specs - Moves article after_save hook from observer into article
- Move controllers - Include rails-observers - Rename ApplicationController to BaseController, since Rails will generate one in the main app, causing the engine's ApplicationController not to be loaded. - Move locale files and publify_lang into engine - Move supporting helpers, services, gems dependencies - Remove email observer and move notification mailing logic - Move '$default_token' global variable - Move googlesitemap mime type - Move sidebar registry and static and search sidebars - Test with plain instead of bootstrap-2 theme - Move ignoring of accept headers - Fix PublifyPlugins registry logic to allow zero plugins to be registered
- Remove require of moved publify_lang file - Ensure rails-observers loads everything
Still allow monkey patching, since disallowing would mean a rather large change to the existing spec files. This is left as a TODO.
The Akismet functionality was completely untested. Now at least the client creation is run once. This needs more work.
- Create plugin with
rails plugin new publify_textfilter_code --dummy-path=spec/dummy \
--skip-test-unit --full --skip-keeps
- Move text filter implementation and dependencies to plugin
- Depend on publify_core
- Generate publify_core migrations and schema with
rake app:publify_core_engine:install:migrations
rake db:migrate
- Configure rspec and its tasks with
rails g rspec:install
- Adjust Rakefile to add spec task and have it run by default
- Move over code filter part of text filter spec
- Adjust rails_helper to load environment from dummy application
- Adjust specs to not need TextFilter objects
We're not supporting 2.0 anymore, so make that clear. This also allows removal of the RUBY_VERSION check for i18n-tasks.
- Include publify_textfilter_code in the Travis run - Ensure sqlite3 is present for gem tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #516.
For this PR:
publify_coreengine, keeping some plug-ins in the main application.generate_test_dummy).Afterward: