From 5530caf9645e89080a3e5be091ed53e2d57c8d75 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 25 Sep 2023 07:40:43 +0000 Subject: [PATCH 1/4] Update rubocop-rspec requirement from ~> 2.23.2 to ~> 2.24.1 Updates the requirements on [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-rspec/releases) - [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-rspec/compare/v2.23.2...v2.24.1) --- updated-dependencies: - dependency-name: rubocop-rspec dependency-type: direct:development ... Signed-off-by: dependabot[bot] --- publify_core.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/publify_core.gemspec b/publify_core.gemspec index 18021342..ff4bbedf 100644 --- a/publify_core.gemspec +++ b/publify_core.gemspec @@ -61,7 +61,7 @@ Gem::Specification.new do |s| s.add_development_dependency "rubocop-factory_bot", "~> 2.24.0" s.add_development_dependency "rubocop-performance", "~> 1.19.0" s.add_development_dependency "rubocop-rails", "~> 2.20.2" - s.add_development_dependency "rubocop-rspec", "~> 2.23.2" + s.add_development_dependency "rubocop-rspec", "~> 2.24.1" s.add_development_dependency "shoulda-matchers", "~> 5.3" s.add_development_dependency "simplecov", "~> 0.22.0" s.add_development_dependency "sqlite3", "~> 1.6" From bbbde95b1dd894599b86468bd0fb5a733f5cd06f Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 29 Sep 2023 14:31:40 +0200 Subject: [PATCH 2/4] Move specs for AuthorsHelper to their proper location --- spec/helpers/{author_helper_spec.rb => authors_helper_spec.rb} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename spec/helpers/{author_helper_spec.rb => authors_helper_spec.rb} (100%) diff --git a/spec/helpers/author_helper_spec.rb b/spec/helpers/authors_helper_spec.rb similarity index 100% rename from spec/helpers/author_helper_spec.rb rename to spec/helpers/authors_helper_spec.rb From ad99e40612b021742fb0575350564dfb0194b1cf Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 29 Sep 2023 14:50:58 +0200 Subject: [PATCH 3/4] Fix describe label for Article::Factory specs --- spec/models/article/factory_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/models/article/factory_spec.rb b/spec/models/article/factory_spec.rb index 9839b7ed..eb426b6a 100644 --- a/spec/models/article/factory_spec.rb +++ b/spec/models/article/factory_spec.rb @@ -2,10 +2,10 @@ require "rails_helper" -RSpec.describe Article::Builder, type: :model do +RSpec.describe Article::Factory, type: :model do let(:blog) { create(:blog) } let(:user) { create(:user) } - let(:factory) { Article::Factory.new(blog, user) } + let(:factory) { described_class.new(blog, user) } describe "#default" do let(:new_article) { factory.default } From 807dd5236f8a7f29092d807f22dfa3eedb078ba4 Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 29 Sep 2023 15:53:50 +0200 Subject: [PATCH 4/4] Regenerate RuboCop to-do file --- .rubocop_todo.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 936a6391..64b6b930 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -114,9 +114,7 @@ RSpec/ExpectInHook: # Include: **/*_spec*rb*, **/spec/**/* RSpec/FilePath: Exclude: - - 'spec/helpers/author_helper_spec.rb' - 'spec/lib/transforms_spec.rb' - - 'spec/models/article/factory_spec.rb' # Configuration parameters: AssignmentOnly. RSpec/InstanceVariable: @@ -174,6 +172,12 @@ RSpec/ScatteredSetup: Exclude: - 'spec/controllers/admin/articles_controller_spec.rb' +# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata. +# Include: **/*_spec.rb +RSpec/SpecFilePathFormat: + Exclude: + - 'spec/lib/transforms_spec.rb' + RSpec/StubbedMock: Exclude: - 'spec/controllers/admin/notes_controller_spec.rb'