Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize error messages #59

Closed

Conversation

parasyte
Copy link

  • "error" key should be "message"
  • "payload" should never be null
  • JSON parse errors are clearly labeled, and include the unparsed payload
  • Timeout errors are clearly labeled
  • Aborted connections include the payload received so far

- "error" key should be "message"
- "payload" should never be null
- JSON parse errors are clearly labeled, and include the unparsed payload
- Timeout errors are clearly labeled
- Aborted connections include the payload received so far
@geremyCohen
Copy link
Contributor

Thanks @parasyte we'll try and process these this week in preparation for our next push.

@MaxPresman
Copy link
Contributor

as javascript web / node v4 was released to stable with a fully rewritten core, we are closing up v3.0 based requests as we move v3 into maintenance mode.

@MaxPresman MaxPresman closed this Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants