New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be secure by default #89

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@petrosagg

petrosagg commented Jun 13, 2017

Following the secure by default[1] software practice, use an encrypted transport by default.

In the current form, any pubnub user with default settings will have their data exposed to network eavesdroppers.

In the same spirit as 2de9ec1

[1] https://en.wikipedia.org/wiki/Secure_by_default

use ssl by default
Following the secure by default[1] software practice, use an encrypted
transport by default.

[1] https://en.wikipedia.org/wiki/Secure_by_default

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>

petrosagg added a commit to resin-io/resin-supervisor that referenced this pull request Jun 13, 2017

enable SSL when connecting to pubnub
Fixes #451

Connected-to: pubnub/javascript#89
Change-Type: patch
Signed-off-by: Petros Angelatos <petrosagg@gmail.com>

@MaxPresman MaxPresman closed this Dec 4, 2017

@petrosagg

This comment has been minimized.

Show comment
Hide comment
@petrosagg

petrosagg Dec 5, 2017

Hey @MaxPresman. I was surprised to see this PR closed. Is there a reason for not accepting it upstream?

petrosagg commented Dec 5, 2017

Hey @MaxPresman. I was surprised to see this PR closed. Is there a reason for not accepting it upstream?

@stephenlb

This comment has been minimized.

Show comment
Hide comment
@stephenlb

stephenlb Dec 29, 2017

Member

Hi @MaxPresman pinged you on company chat.

Member

stephenlb commented Dec 29, 2017

Hi @MaxPresman pinged you on company chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment