From dd5fee292c4144517a147b1ecfe1a6ecf1fe9c6b Mon Sep 17 00:00:00 2001 From: "marcin.cebo" Date: Tue, 17 Jun 2025 11:40:15 +0200 Subject: [PATCH] Removed unused PNMalformedResponseCategory --- .../pubnub-kotlin-api/config/ktlint/baseline.xml | 1 + .../src/appleMain/kotlin/com/pubnub/kmp/factories.ios.kt | 3 --- .../pubnub-kotlin-api/src/jsMain/kotlin/Pubnub.d.kt | 1 - .../kotlin/com/pubnub/api/enums/PNStatusCategory.kt | 8 -------- .../suite/history/v3/FetchMessagesMetaActionsTestSuite.kt | 1 - .../internal/suite/history/v3/FetchMessagesTestSuite.kt | 1 - 6 files changed, 1 insertion(+), 14 deletions(-) diff --git a/pubnub-kotlin/pubnub-kotlin-api/config/ktlint/baseline.xml b/pubnub-kotlin/pubnub-kotlin-api/config/ktlint/baseline.xml index f3b669e202..fb3ecdb71d 100644 --- a/pubnub-kotlin/pubnub-kotlin-api/config/ktlint/baseline.xml +++ b/pubnub-kotlin/pubnub-kotlin-api/config/ktlint/baseline.xml @@ -43,6 +43,7 @@ + diff --git a/pubnub-kotlin/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/kmp/factories.ios.kt b/pubnub-kotlin/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/kmp/factories.ios.kt index d6dff35160..9bd4b66e46 100644 --- a/pubnub-kotlin/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/kmp/factories.ios.kt +++ b/pubnub-kotlin/pubnub-kotlin-api/src/appleMain/kotlin/com/pubnub/kmp/factories.ios.kt @@ -7,7 +7,6 @@ import cocoapods.PubNubSwift.KMPConnectionStatusCategoryDisconnected import cocoapods.PubNubSwift.KMPConnectionStatusCategoryDisconnectedUnexpectedly import cocoapods.PubNubSwift.KMPConnectionStatusCategoryHeartbeatFailed import cocoapods.PubNubSwift.KMPConnectionStatusCategoryHeartbeatSuccess -import cocoapods.PubNubSwift.KMPConnectionStatusCategoryMalformedResponseCategory import cocoapods.PubNubSwift.KMPConnectionStatusCategorySubscriptionChanged import cocoapods.PubNubSwift.KMPEventListener import cocoapods.PubNubSwift.KMPFileChangeEvent @@ -347,8 +346,6 @@ actual fun createStatusListener( PNStatusCategory.PNUnexpectedDisconnectCategory KMPConnectionStatusCategoryConnectionError -> PNStatusCategory.PNConnectionError - KMPConnectionStatusCategoryMalformedResponseCategory -> - PNStatusCategory.PNMalformedResponseCategory KMPConnectionStatusCategoryHeartbeatFailed -> PNStatusCategory.PNHeartbeatFailed KMPConnectionStatusCategoryHeartbeatSuccess -> diff --git a/pubnub-kotlin/pubnub-kotlin-api/src/jsMain/kotlin/Pubnub.d.kt b/pubnub-kotlin/pubnub-kotlin-api/src/jsMain/kotlin/Pubnub.d.kt index b1ee8c00e0..4326ed99aa 100644 --- a/pubnub-kotlin/pubnub-kotlin-api/src/jsMain/kotlin/Pubnub.d.kt +++ b/pubnub-kotlin/pubnub-kotlin-api/src/jsMain/kotlin/Pubnub.d.kt @@ -1452,7 +1452,6 @@ external interface Categories { var PNReconnectedCategory: String var PNConnectedCategory: String var PNRequestMessageCountExceedCategory: String - var PNMalformedResponseCategory: String var PNDisconnectedUnexpectedlyCategory: String var PNConnectionErrorCategory: String } diff --git a/pubnub-kotlin/pubnub-kotlin-core-api/src/commonMain/kotlin/com/pubnub/api/enums/PNStatusCategory.kt b/pubnub-kotlin/pubnub-kotlin-core-api/src/commonMain/kotlin/com/pubnub/api/enums/PNStatusCategory.kt index 7054bf7741..7e752d88e9 100644 --- a/pubnub-kotlin/pubnub-kotlin-core-api/src/commonMain/kotlin/com/pubnub/api/enums/PNStatusCategory.kt +++ b/pubnub-kotlin/pubnub-kotlin-core-api/src/commonMain/kotlin/com/pubnub/api/enums/PNStatusCategory.kt @@ -43,12 +43,4 @@ enum class PNStatusCategory { * A background implicit Heartbeat request was successful. */ PNHeartbeatSuccess, - - /** - * PubNub sent a malformed response. - * This may happen when you connect to a public WiFi Hotspot that requires you to auth via your web browser first, - * or if there is a proxy somewhere returning an HTML access denied error, - * or if there was an intermittent server issue. - */ - PNMalformedResponseCategory, } diff --git a/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesMetaActionsTestSuite.kt b/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesMetaActionsTestSuite.kt index 4192eb87f6..9cd9b14702 100644 --- a/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesMetaActionsTestSuite.kt +++ b/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesMetaActionsTestSuite.kt @@ -116,7 +116,6 @@ class FetchMessagesMetaActionsTestSuite : pnError = PubNubError.PARSING_ERROR additionalChecks = { result -> assertTrue(result.isFailure) -// assertEquals(PNStatusCategory.PNMalformedResponseCategory, status.category) } }, ) diff --git a/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesTestSuite.kt b/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesTestSuite.kt index 7331c83192..a8f53944c2 100644 --- a/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesTestSuite.kt +++ b/pubnub-kotlin/pubnub-kotlin-impl/src/test/kotlin/com/pubnub/internal/suite/history/v3/FetchMessagesTestSuite.kt @@ -90,7 +90,6 @@ class FetchMessagesTestSuite : com.pubnub.internal.suite.CoreEndpointTestSuite assertTrue(result.isFailure) -// assertEquals(PNStatusCategory.PNMalformedResponseCategory, status.category) } }, )