From 7659a753a2de877ba3e0f577c57882019e357610 Mon Sep 17 00:00:00 2001 From: Serhii Mamontov Date: Fri, 24 Sep 2021 11:37:13 +0300 Subject: [PATCH 1/5] fix(request): fix request mutators apply Fix issue because of which request with applied mutators not used. --- Sources/PubNub/Networking/HTTPSession.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/PubNub/Networking/HTTPSession.swift b/Sources/PubNub/Networking/HTTPSession.swift index 19fe9f46..42fe9004 100644 --- a/Sources/PubNub/Networking/HTTPSession.swift +++ b/Sources/PubNub/Networking/HTTPSession.swift @@ -177,7 +177,7 @@ final class HTTPSession { switch result { case let .success(mutatedRequest): request.didMutate(urlRequest, to: mutatedRequest) - self?.didCreateURLRequest(urlRequest, for: request) + self?.didCreateURLRequest(mutatedRequest, for: request) case let .failure(error): request.didFailToMutate(urlRequest, with: error) } From a855d110bb94adb978d2e0eea95a68fca46fe149 Mon Sep 17 00:00:00 2001 From: Serhii Mamontov Date: Fri, 5 Nov 2021 02:35:05 +0200 Subject: [PATCH 2/5] refactor(codeowners): update list of codeowners Update list of codeowners and files for which they responsible. build: integrate with release notifications Add support for release process notifications. --- .github/CODEOWNERS | 4 ++-- .github/workflows/releasae.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index a807241b..98a5ace3 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,3 +1,3 @@ * @parfeon @CraigLn -README.md @crimsonred @techwritermat -.pubnub.yml @crimsonred @techwritermat +.github/* @parfeon @CraigLn +README.md @techwritermat @kazydek diff --git a/.github/workflows/releasae.yml b/.github/workflows/releasae.yml index 3f960410..a41ad5e0 100644 --- a/.github/workflows/releasae.yml +++ b/.github/workflows/releasae.yml @@ -53,5 +53,5 @@ jobs: uses: ./.github/.release/actions/actions/services/github-release with: token: ${{ secrets.GH_TOKEN }} + jira-api-key: ${{ secrets.JIRA_API_KEY }} last-service: true - From e5bd53b418938b7d5334aa79cba4b682ce02310a Mon Sep 17 00:00:00 2001 From: Client Engineering Bot Date: Fri, 5 Nov 2021 00:39:40 +0000 Subject: [PATCH 3/5] PubNub SDK 4.1.1 release. --- .pubnub.yml | 9 +++++++-- PubNub.xcodeproj/project.pbxproj | 4 ++-- PubNubSwift.podspec | 2 +- Sources/PubNub/Helpers/Constants.swift | 2 +- 4 files changed, 11 insertions(+), 6 deletions(-) diff --git a/.pubnub.yml b/.pubnub.yml index 0dc5a248..c622ea23 100644 --- a/.pubnub.yml +++ b/.pubnub.yml @@ -1,9 +1,14 @@ --- name: swift scm: github.com/pubnub/swift -version: "4.1.0" +version: "4.1.1" schema: 1 changelog: + - date: 2021-11-05 + version: 4.1.1 + changes: + - type: bug + text: "Fix issue because of which request with applied mutators not used." - date: 2021-09-16 version: 4.1.0 changes: @@ -419,7 +424,7 @@ sdks: - distribution-type: source distribution-repository: GitHub release package-name: PubNub - location: https://github.com/pubnub/swift/archive/refs/tags/4.1.0.zip + location: https://github.com/pubnub/swift/archive/refs/tags/4.1.1.zip supported-platforms: supported-operating-systems: macOS: diff --git a/PubNub.xcodeproj/project.pbxproj b/PubNub.xcodeproj/project.pbxproj index df9a957a..a14b19e5 100644 --- a/PubNub.xcodeproj/project.pbxproj +++ b/PubNub.xcodeproj/project.pbxproj @@ -2514,7 +2514,7 @@ "$(inherited)", "$(TOOLCHAIN_DIR)/usr/lib/swift/macosx", ); - MARKETING_VERSION = 4.1.0; + MARKETING_VERSION = 4.1.1; OTHER_CFLAGS = "$(inherited)"; OTHER_LDFLAGS = "$(inherited)"; OTHER_SWIFT_FLAGS = "$(inherited)"; @@ -2547,7 +2547,7 @@ "$(inherited)", "$(TOOLCHAIN_DIR)/usr/lib/swift/macosx", ); - MARKETING_VERSION = 4.1.0; + MARKETING_VERSION = 4.1.1; OTHER_CFLAGS = "$(inherited)"; OTHER_LDFLAGS = "$(inherited)"; OTHER_SWIFT_FLAGS = "$(inherited)"; diff --git a/PubNubSwift.podspec b/PubNubSwift.podspec index 8f24a86d..1e19f952 100644 --- a/PubNubSwift.podspec +++ b/PubNubSwift.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = 'PubNubSwift' - s.version = '4.1.0' + s.version = '4.1.1' s.homepage = 'https://github.com/pubnub/swift' s.documentation_url = 'https://www.pubnub.com/docs/swift-native/pubnub-swift-sdk' s.authors = { 'PubNub, Inc.' => 'support@pubnub.com' } diff --git a/Sources/PubNub/Helpers/Constants.swift b/Sources/PubNub/Helpers/Constants.swift index daf62368..75c70083 100644 --- a/Sources/PubNub/Helpers/Constants.swift +++ b/Sources/PubNub/Helpers/Constants.swift @@ -62,7 +62,7 @@ public struct Constant { }() static let pubnubSwiftSDKVersion: String = { - "4.1.0" + "4.1.1" }() static let appBundleId: String = { From 92a78ce0f3127886303bd2fa9a782a819f1c35bf Mon Sep 17 00:00:00 2001 From: Serhii Mamontov Date: Fri, 5 Nov 2021 02:43:09 +0200 Subject: [PATCH 4/5] build: add missing API key Commands processor was missing API key in workflow. --- .github/workflows/commands-handler.yml | 1 + .pubnub.yml | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/commands-handler.yml b/.github/workflows/commands-handler.yml index d7401e17..e5196c1b 100644 --- a/.github/workflows/commands-handler.yml +++ b/.github/workflows/commands-handler.yml @@ -24,3 +24,4 @@ jobs: with: token: ${{ secrets.GH_TOKEN }} listener: client-engineering-bot + jira-api-key: ${{ secrets.JIRA_API_KEY }} diff --git a/.pubnub.yml b/.pubnub.yml index c622ea23..46a2a4f7 100644 --- a/.pubnub.yml +++ b/.pubnub.yml @@ -4,11 +4,6 @@ scm: github.com/pubnub/swift version: "4.1.1" schema: 1 changelog: - - date: 2021-11-05 - version: 4.1.1 - changes: - - type: bug - text: "Fix issue because of which request with applied mutators not used." - date: 2021-09-16 version: 4.1.0 changes: From 4cd7eb33488726811d83780480e35b285995e329 Mon Sep 17 00:00:00 2001 From: Client Engineering Bot Date: Fri, 5 Nov 2021 00:45:22 +0000 Subject: [PATCH 5/5] PubNub SDK 4.1.1 release. --- .pubnub.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.pubnub.yml b/.pubnub.yml index 46a2a4f7..c622ea23 100644 --- a/.pubnub.yml +++ b/.pubnub.yml @@ -4,6 +4,11 @@ scm: github.com/pubnub/swift version: "4.1.1" schema: 1 changelog: + - date: 2021-11-05 + version: 4.1.1 + changes: + - type: bug + text: "Fix issue because of which request with applied mutators not used." - date: 2021-09-16 version: 4.1.0 changes: