Skip to content

Update highlightPaper added background option#35

Closed
marcuwynu23 wants to merge 1 commit into
puffinsoft:masterfrom
marcuwynu23:master
Closed

Update highlightPaper added background option#35
marcuwynu23 wants to merge 1 commit into
puffinsoft:masterfrom
marcuwynu23:master

Conversation

@marcuwynu23

@marcuwynu23 marcuwynu23 commented Jul 29, 2025

Copy link
Copy Markdown

Hi there,

I’ve made a contribution to the highlightPaper function in the jscanify repository by adding a new option to customize the background. This will allow users to adjust the background for improved document scanning and highlighting functionality.

What’s Changed:
Updated the highlightPaper function: Added a background option for better flexibility in user customization.

This change helps provide a more adaptable scanning experience. I believe this will be beneficial for users who need better control over the appearance of the scanned document.

Please feel free to review and merge this PR if it aligns with the project’s goals. Let me know if you need any further adjustments or improvements!

Thank you for the opportunity to contribute!

@ColonelParrot

Copy link
Copy Markdown
Member

Really appreciate your PR! However, there are a lot of changes for a relatively minute feature addition, I just don't feel comfortable merging this.

@marcuwynu23

Copy link
Copy Markdown
Author

Hi, sorry for the very late reply — I somehow missed this notification back in December 😅

Thanks for taking the time to review the PR and for the feedback. I understand the concern about the size of the changes.

I originally contributed this because I’m using this project in one of my own projects and thought the background option might be helpful.

If you ever feel that feature would be useful, I’d be happy to revisit it and submit a smaller change.

Thanks again for maintaining the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants