Update highlightPaper added background option#35
Closed
marcuwynu23 wants to merge 1 commit into
Closed
Conversation
Member
|
Really appreciate your PR! However, there are a lot of changes for a relatively minute feature addition, I just don't feel comfortable merging this. |
Author
|
Hi, sorry for the very late reply — I somehow missed this notification back in December 😅 Thanks for taking the time to review the PR and for the feedback. I understand the concern about the size of the changes. I originally contributed this because I’m using this project in one of my own projects and thought the background option might be helpful. If you ever feel that feature would be useful, I’d be happy to revisit it and submit a smaller change. Thanks again for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I’ve made a contribution to the highlightPaper function in the jscanify repository by adding a new option to customize the background. This will allow users to adjust the background for improved document scanning and highlighting functionality.
What’s Changed:
Updated the highlightPaper function: Added a background option for better flexibility in user customization.
This change helps provide a more adaptable scanning experience. I believe this will be beneficial for users who need better control over the appearance of the scanned document.
Please feel free to review and merge this PR if it aligns with the project’s goals. Let me know if you need any further adjustments or improvements!
Thank you for the opportunity to contribute!